Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issue 2255683004: Revert of Batched implementation of drawLattice() for GPU (Closed)

Created:
4 years, 4 months ago by msarett
Modified:
4 years, 4 months ago
Reviewers:
bsalomon, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Batched implementation of drawLattice() for GPU (patchset #7 id:180001 of https://codereview.chromium.org/2255963002/ ) Reason for revert: Things drawing weird. Original issue's description: > Batched implementation of drawLattice() for GPU > > Bechmarks (Nexus 6P): > > Src=100x100, Dst=250x250, NumRects=9 > Android 77.7us > Skia (without patch) 57.2us > Skia (with patch) 34.7us > > Src=100x100, Dst=500x500, NumRects=9 > Android 77.0us > Skia (without patch) 56.9us > Skia (with patch) 44.5us > > Src=100x100, Dst=1000x1000, NumRects=9 > Android 180us > Skia (without patch) 96.8us > Skia (with patch) 70.5us > > Src=100x100, Dst=250x250, NumRects=15 > Android 208us > Skia (without patch) 155us > Skia (with patch) 55.9us > > Src=100x100, Dst=500x500, NumRects=15 > Android 207us > Skia (without patch) 152us > Skia (with patch) 63.0us > > Src=100x100, Dst=1000x1000, NumRects=15 > Android 233us > Skia (without patch) 156us > Skia (with patch) 99.9us > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255963002 > > Committed: https://skia.googlesource.com/skia/+/93242c4ae50dfcc0d922cdb3ba80bbc7b4bbe93d TBR=bsalomon@google.com,reed@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/7fc08585d0d4daada1c8600b6cdef970ee6c2369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -187 lines) Patch
M bench/DrawLatticeBench.cpp View 2 chunks +3 lines, -18 lines 0 comments Download
M include/gpu/GrDrawContext.h View 2 chunks +20 lines, -10 lines 0 comments Download
M include/private/SkTArray.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/core/SkLatticeIter.h View 1 chunk +2 lines, -15 lines 0 comments Download
M src/core/SkLatticeIter.cpp View 3 chunks +0 lines, -17 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +12 lines, -14 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -59 lines 0 comments Download
M src/gpu/batches/GrNinePatch.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/batches/GrNinePatch.cpp View 6 chunks +21 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Batched implementation of drawLattice() for GPU
4 years, 4 months ago (2016-08-18 21:29:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255683004/1
4 years, 4 months ago (2016-08-18 21:29:19 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 21:29:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7fc08585d0d4daada1c8600b6cdef970ee6c2369

Powered by Google App Engine
This is Rietveld 408576698