Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2255683002: Convert editing/style/style-boundary-00[1-4].html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/style/style-boundary-00[1-4].html to use w3c test harness This patch converts "editing/style/style-boundary-00[1-4].html" to use w3c test harness and consolidates into "style_boundary.html" to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/6c64b37279479e901a6f81d400ff7726084cdc1a Cr-Commit-Position: refs/heads/master@{#412470}

Patch Set 1 : 2016-08-17T13:43:12 #

Total comments: 2

Patch Set 2 : 2016-08-17T15:36:31 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -699 lines) Patch
D third_party/WebKit/LayoutTests/editing/style/style-boundary-001.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/style/style-boundary-002.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/style/style-boundary-003.html View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/style/style-boundary-004.html View 1 chunk +0 lines, -58 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/style/style_boundary.html View 1 1 chunk +64 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/style-boundary-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/style-boundary-001-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/style-boundary-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/style-boundary-002-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/style-boundary-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/style-boundary-003-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/style-boundary-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/style/style-boundary-004-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/style-boundary-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/style-boundary-001-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/style-boundary-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/style-boundary-002-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/style-boundary-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/style-boundary-003-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/style-boundary-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/style/style-boundary-004-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/style-boundary-001-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/style-boundary-001-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/style-boundary-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/style-boundary-002-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/style-boundary-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/style-boundary-003-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/style-boundary-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/style/style-boundary-004-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-17 05:11:45 UTC) #5
Xiaocheng
https://codereview.chromium.org/2255683002/diff/1/third_party/WebKit/LayoutTests/editing/style/style_boundary.html File third_party/WebKit/LayoutTests/editing/style/style_boundary.html (right): https://codereview.chromium.org/2255683002/diff/1/third_party/WebKit/LayoutTests/editing/style/style_boundary.html#newcode54 third_party/WebKit/LayoutTests/editing/style/style_boundary.html:54: '<div><div><b>a</b></div><div>^b|</div></div>', The initial selection should be something like '<div><div><b>a^</b></div><div>b|</div></div>', ...
4 years, 4 months ago (2016-08-17 05:56:48 UTC) #6
yosin_UTC9
PTAL https://codereview.chromium.org/2255683002/diff/1/third_party/WebKit/LayoutTests/editing/style/style_boundary.html File third_party/WebKit/LayoutTests/editing/style/style_boundary.html (right): https://codereview.chromium.org/2255683002/diff/1/third_party/WebKit/LayoutTests/editing/style/style_boundary.html#newcode54 third_party/WebKit/LayoutTests/editing/style/style_boundary.html:54: '<div><div><b>a</b></div><div>^b|</div></div>', On 2016/08/17 at 05:56:48, Xiaocheng wrote: > ...
4 years, 4 months ago (2016-08-17 06:39:53 UTC) #8
Xiaocheng
lgtm
4 years, 4 months ago (2016-08-17 06:58:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255683002/20001
4 years, 4 months ago (2016-08-17 07:02:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 07:53:01 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 08:11:24 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c64b37279479e901a6f81d400ff7726084cdc1a
Cr-Commit-Position: refs/heads/master@{#412470}

Powered by Google App Engine
This is Rietveld 408576698