Chromium Code Reviews
DescriptionRevert of [M53 cherry-pick] Migrate ArcUserDataService into ArcAuthService. (patchset #1 id:1 of https://codereview.chromium.org/2248353002/ )
Reason for revert:
Compilation problem:
../../chrome/browser/chromeos/arc/arc_auth_service.cc:244:34: error: no member named 'stopped' in 'arc::ArcBridgeService'
Original issue's description:
> Migrate ArcUserDataService into ArcAuthService.
>
> There are race problems around data removing.
> One of the cause is that state management is done in
> ArcAuthService and ArcUserDataService separately.
>
> This CL migrates ArcUserDataService into ArcAuthService
> so that we can remove the data when necessary.
>
> BUG=633258, 636218
> TEST=Ran manually.
> - "Enable -> ARC boot wait -> Disable" triggers data removal after
> ARC stop.
> - "Enable -> Disable before ARC boot" triggers immediate data
> removal.
> - "Enable -> ARC boot wait -> Kill ARC instance" does not trigger
> data removal.
> R=dspaid@chromium.org, lhchavez@chromium.org
> TBR=khmel@chromium.org, lhchavez@chromium.org, stevenjb@chromium.org
>
> Review-Url: https://codereview.chromium.org/2209173002
> Cr-Commit-Position: refs/heads/master@{#411923}
> (cherry picked from commit 6d95ad318e992261c45f5a88a0a599663a6d66ae)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/d7ca35a59c7bd8c7ddd78d7682458e48e6b4e934
TBR=dspaid@chromium.org,lhchavez@chromium.org,stevenjb@chromium.org,hidehiko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=633258, 636218
Patch Set 1 #Messages
Total messages: 5 (2 generated)
|