remoting/client/jni/jni_gl_display_handler.cc - Issue 2255663002: [Remoting Android] Use floating point coords for rendering the cursor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/jni/jni_gl_display_handler.cc

Issue 2255663002: [Remoting Android] Use floating point coords for rendering the cursor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java ('K') | « remoting/client/jni/jni_gl_display_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/client/jni/jni_gl_display_handler.cc

diff --git a/remoting/client/jni/jni_gl_display_handler.cc b/remoting/client/jni/jni_gl_display_handler.cc

index 114d48ea11184d8d8efcfbd99e220f88a2f74109..4b6d23084551fb1b0170697deb9e7a9244131648 100644

--- a/remoting/client/jni/jni_gl_display_handler.cc

+++ b/remoting/client/jni/jni_gl_display_handler.cc

@@ -115,8 +115,8 @@ void JniGlDisplayHandler::OnPixelTransformationChanged(

void JniGlDisplayHandler::OnCursorPixelPositionChanged(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& caller,

- int x,

- int y) {

+ float x,

+ float y) {

DCHECK(runtime_->ui_task_runner()->BelongsToCurrentThread());

ui_task_poster_->AddTask(base::Bind(&GlRenderer::OnCursorMoved,

renderer_.GetWeakPtr(), x, y));

@@ -134,8 +134,8 @@ void JniGlDisplayHandler::OnCursorVisibilityChanged(

void JniGlDisplayHandler::OnCursorInputFeedback(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& caller,

- int x,

- int y,

+ float x,

+ float y,

float diameter) {

DCHECK(runtime_->ui_task_runner()->BelongsToCurrentThread());

ui_task_poster_->AddTask(base::Bind(&GlRenderer::OnCursorInputFeedback,

« remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java ('K') | « remoting/client/jni/jni_gl_display_handler.h ('k') | no next file » | no next file with comments »