tools/json_schema_compiler/feature_compiler.py - Issue 2255613003: Introduce session type parameter to extension features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/feature_compiler.py

Issue 2255613003: Introduce session type parameter to extension features (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Introduce session type parameter to extension features Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/features/simple_feature_unittest.cc ('K') | « extensions/common/features/simple_feature_unittest.cc ('k') | tools/json_schema_compiler/feature_compiler_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/json_schema_compiler/feature_compiler.py

diff --git a/tools/json_schema_compiler/feature_compiler.py b/tools/json_schema_compiler/feature_compiler.py

index d28880220ec5ccfe3adc560cc9174b4b49afb717..173bc178ead431d3da7203d9b7c9ed8f3216b6fc 100644

--- a/tools/json_schema_compiler/feature_compiler.py

+++ b/tools/json_schema_compiler/feature_compiler.py

@@ -189,6 +189,14 @@ FEATURE_GRAMMAR = (

}

+ 'session_types': {

+ list: {

+ 'enum_map': {

+ 'regular': 'FeatureSessionType::REGULAR',

+ 'kiosk': 'FeatureSessionType::KIOSK',

+ }

+ },

'whitelist': {

list: {'subtype': unicode}