Chromium Code Reviews Chromium Code Reviews
Issue 2255613003:
Introduce session type parameter to extension features (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 # Extension Features Files | 1 # Extension Features Files |
| 2 | 2 |
| 3 [TOC] | 3 [TOC] |
| 4 | 4 |
| 5 ## Summary | 5 ## Summary |
| 6 | 6 |
| 7 The Extension features files specify the different requirements for extension | 7 The Extension features files specify the different requirements for extension |
| 8 feature availability. | 8 feature availability. |
| 9 | 9 |
| 10 An **extension feature** can be any component of extension capabilities. Most | 10 An **extension feature** can be any component of extension capabilities. Most |
| (...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 246 The only accepted value is the bool `true`. | 246 The only accepted value is the bool `true`. |
| 247 | 247 |
| 248 ### platforms | 248 ### platforms |
| 249 | 249 |
| 250 The `platforms` property specifies the properties the feature should be | 250 The `platforms` property specifies the properties the feature should be |
| 251 available on. | 251 available on. |
| 252 | 252 |
| 253 The accepted values are lists of strings from `chromeos`, `mac`, `linux`, and | 253 The accepted values are lists of strings from `chromeos`, `mac`, `linux`, and |
| 254 `win`. | 254 `win`. |
| 255 | 255 |
| 256 ### session\_types | |
| 257 | |
| 258 The `session_types` property specifies in which types of sessions a feature | |
| 259 should be available. The session type describes the type of user that is | |
| 260 logged in the current session. | |
|
Devlin
2016/09/13 16:46:23
What happens if the user is not logged in? Specif
tbarzic
2016/09/13 17:23:49
They currently don't make sense on non-chromeos, I
| |
| 261 | |
| 262 The accepted values are lists of strings from `regular` and `kiosk`. | |
| 263 | |
| 256 ### whitelist | 264 ### whitelist |
| 257 | 265 |
| 258 The `whitelist` property specifies a list of ID hashes for extensions that | 266 The `whitelist` property specifies a list of ID hashes for extensions that |
| 259 are the only extensions allowed to access a feature. | 267 are the only extensions allowed to access a feature. |
| 260 | 268 |
| 261 Accepted values are lists of id hashes. | 269 Accepted values are lists of id hashes. |
| 262 | 270 |
| 263 ## ID Hashes | 271 ## ID Hashes |
| 264 | 272 |
| 265 Instead of listing the ID directly in the whitelist or blacklist section, we | 273 Instead of listing the ID directly in the whitelist or blacklist section, we |
| (...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 370 at runtime, this has the added benefit of allowing us to validate at compile | 378 at runtime, this has the added benefit of allowing us to validate at compile |
| 371 time rather than needing a unittest (or allowing incorrect features). | 379 time rather than needing a unittest (or allowing incorrect features). |
| 372 | 380 |
| 373 In theory, invalid features should result in a compilation failure; in practice, | 381 In theory, invalid features should result in a compilation failure; in practice, |
| 374 the compiler is probably missing some cases. | 382 the compiler is probably missing some cases. |
| 375 | 383 |
| 376 ## Still to come | 384 ## Still to come |
| 377 | 385 |
| 378 TODO(devlin): Add documentation for extension types. Probably also more on | 386 TODO(devlin): Add documentation for extension types. Probably also more on |
| 379 requirements for individual features. | 387 requirements for individual features. |
| OLD | NEW |
