chrome/test/data/extensions/extension_api_unittest/api_features.json - Issue 2255613003: Introduce session type parameter to extension features

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/extension_api_unittest/api_features.json

Issue 2255613003: Introduce session type parameter to extension features (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Introduce session type parameter to extension features Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/api/common_extension_api_unittest.cc ('K') | « chrome/common/extensions/api/common_extension_api_unittest.cc ('k') | extensions/common/features/feature.h » ('j') | extensions/common/features/simple_feature_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "test1": {	2 "test1": {

3 "channel": "stable",	3 "channel": "stable",

4 "contexts": ["content_script", "blessed_extension", "unblessed_extension"],	4 "contexts": ["content_script", "blessed_extension", "unblessed_extension"],

5 "extension_types": ["extension"]	5 "extension_types": ["extension"]

6 },	6 },

7 "test2": {	7 "test2": {

8 "channel": "stable",	8 "channel": "stable",

9 "contexts": ["web_page"],	9 "contexts": ["web_page"],

10 "matches": ["<all_urls>"]	10 "matches": ["<all_urls>"]

(...skipping 73 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
84 "parent3": {	84 "parent3": {

85 "dependencies": ["api:parent1"],	85 "dependencies": ["api:parent1"],

86 "contexts": ["content_script", "blessed_extension", "unblessed_extension"]	86 "contexts": ["content_script", "blessed_extension", "unblessed_extension"]

87 },	87 },

88 "parent3.noparent": {	88 "parent3.noparent": {

89 "channel": "stable",	89 "channel": "stable",

90 "noparent": true,	90 "noparent": true,

91 "contexts": ["content_script", "blessed_extension", "unblessed_extension"]	91 "contexts": ["content_script", "blessed_extension", "unblessed_extension"]

92 },	92 },

93 "parent3.noparent.child": {	93 "parent3.noparent.child": {

	94 },

	95 "kiosk_only": {

	96 "channel": "stable",

	97 "contexts": ["content_script", "blessed_extension", "unblessed_extension"],

	98 "session_types": ["kiosk"]

	99 },

	100 "non_kiosk": {

	101 "channel": "stable",

	102 "contexts": ["content_script", "blessed_extension", "unblessed_extension"],

	103 "session_types": ["regular"]
	rkc 2016/08/18 20:35:28 Can we add a test for no session type, and both se Can we add a test for no session type, and both session types specified? i.e., "session_types": [] and "session_types": ["kiosk", "regular"] It would be nice if we could also add a few negative tests. Something like "session_types": ["garbage"] tbarzic 2016/08/18 22:18:56 Done Show quoted text On 2016/08/18 at 20:35:28, rkc wrote: > Can we add a test for no session type, and both session types specified? > i.e., "session_types": [] and "session_types": ["kiosk", "regular"] > > It would be nice if we could also add a few negative tests. Something like "session_types": ["garbage"] Done
94 }	104 }

95 }	105 }

OLD	NEW