runtime/observatory/lib/src/elements/cpu_profile.dart - Issue 2255613002: Converted Observatory heap-profile element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/cpu_profile.dart

Issue 2255613002: Converted Observatory heap-profile element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Optimizations & Dead code removal Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/cpu_profile.dart

diff --git a/runtime/observatory/lib/src/elements/cpu_profile.dart b/runtime/observatory/lib/src/elements/cpu_profile.dart

index 0b24b07481f76ea90bf9023d4ca9eb81692f6ee6..014fd807fe2dd4345a0d379dc5fd538eb5cc04d9 100644

--- a/runtime/observatory/lib/src/elements/cpu_profile.dart

+++ b/runtime/observatory/lib/src/elements/cpu_profile.dart

@@ -29,7 +29,6 @@ class CpuProfileElement extends HtmlElement implements Renderable {

NavVMMenuElement.tag,

NavIsolateMenuElement.tag,

NavMenuElement.tag,

- NavMenuElement.tag,

NavRefreshElement.tag,

NavNotifyElement.tag,

SampleBufferControlElement.tag,

@@ -90,7 +89,8 @@ class CpuProfileElement extends HtmlElement implements Renderable {

@override

detached() {

- super.detached(); _r.disable(notify: true);

+ super.detached();

+ _r.disable(notify: true);

children = [];

}