Converted Observatory heap-profile element

runtime/vm/class_table.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/class_table.h"
 
 #include "vm/atomic.h"
 #include "vm/flags.h"
 #include "vm/freelist.h"
 #include "vm/growable_array.h"
@@ skipping 503 matching lines @@
 void ClassTable::AllocationProfilePrintJSON(JSONStream* stream) {
   if (!FLAG_support_service) {
     return;
   }
   Isolate* isolate = Isolate::Current();
   ASSERT(isolate != NULL);
   Heap* heap = isolate->heap();
   ASSERT(heap != NULL);
   JSONObject obj(stream);
   obj.AddProperty("type", "AllocationProfile");
-  obj.AddPropertyF(
-      "dateLastAccumulatorReset",
-      "%" Pd64 "",
-      isolate->last_allocationprofile_accumulator_reset_timestamp());
-  obj.AddPropertyF(
-      "dateLastServiceGC",
-      "%" Pd64 "",
-      isolate->last_allocationprofile_gc_timestamp());
+  if (isolate->last_allocationprofile_accumulator_reset_timestamp()) {

[Cutch, 2016/08/17 17:35:10]

the type of

isolate->last_allocationprofile_accumulator_reset_timestamp()

is int64_t

Please change this so that the expression is a bool:

isolate->last_allocationprofile_accumulator_reset_timestamp() != 0

[cbernaschina, 2016/08/17 17:55:52]

Done.

+    obj.AddPropertyF(
+        "dateLastAccumulatorReset",
+        "%" Pd64 "",
+        isolate->last_allocationprofile_accumulator_reset_timestamp());
+  }
+  if (isolate->last_allocationprofile_gc_timestamp()) {

[Cutch, 2016/08/17 17:35:10]

ditto

[cbernaschina, 2016/08/17 17:55:52]

Done.

+    obj.AddPropertyF(
+        "dateLastServiceGC",
+        "%" Pd64 "",
+        isolate->last_allocationprofile_gc_timestamp());
+  }
 
   {
     JSONObject heaps(&obj, "heaps");
     {
       heap->PrintToJSONObject(Heap::kNew, &heaps);
     }
     {
       heap->PrintToJSONObject(Heap::kOld, &heaps);
     }
   }
@@ skipping 34 matching lines @@
 void ClassTable::UpdateLiveNew(intptr_t cid, intptr_t size) {
   ClassHeapStats* stats = PreliminaryStatsAt(cid);
   ASSERT(stats != NULL);
   ASSERT(size >= 0);
   stats->post_gc.AddNew(size);
 }
 #endif  // !PRODUCT
 
 
 }  // namespace dart