Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 22556002: Add frame pointer markup to grokdump. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger
Modified:
7 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Add frame pointer markup to grokdump. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/grokdump.py View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 4 months ago (2013-08-07 08:47:12 UTC) #1
Yang
On 2013/08/07 08:47:12, Michael Starzinger wrote: LGTM.
7 years, 4 months ago (2013-08-07 08:55:12 UTC) #2
Michael Starzinger
7 years, 4 months ago (2013-08-07 08:57:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698