Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2255533003: [turbofan] Remove representation axis for float64 fields. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove representation axis for float64 fields. This removes the representation axis from the type of {Load/StoreField} operators representing a property load/store. The representation would be narrowed to {None} which causes problems for all places where we use the type to reason about the value representation. Instead we should fully switch to {MachineRepresentation}. This is just a stop-gap fix. R=jarin@chromium.org BUG=chromium:636716 Committed: https://crrev.com/5c6719fcd21c1af25afe5e30f5c1c95803b3f7ed Cr-Commit-Position: refs/heads/master@{#38678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/compiler/js-native-context-specialization.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/types-fuzz.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Starzinger
4 years, 4 months ago (2016-08-17 10:42:28 UTC) #3
Jarin
lgtm. Thanks!
4 years, 4 months ago (2016-08-17 11:02:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255533003/1
4 years, 4 months ago (2016-08-17 11:13:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 11:15:35 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5c6719fcd21c1af25afe5e30f5c1c95803b3f7ed Cr-Commit-Position: refs/heads/master@{#38678}
4 years, 4 months ago (2016-08-17 11:15:48 UTC) #11
Benedikt Meurer
4 years, 4 months ago (2016-08-17 17:18:02 UTC) #13
Message was sent while issue was closed.
Awesome, thanks.

Powered by Google App Engine
This is Rietveld 408576698