blimp/client/core/contents/android/blimp_contents_jni_registrar.cc - Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/android/blimp_contents_jni_registrar.cc

Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass TabControlFeature* to BlimpContentsImpl's constructor, remove blimp contents factory Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/contents/android/blimp_contents_jni_registrar.cc

diff --git a/blimp/client/core/contents/android/blimp_contents_jni_registrar.cc b/blimp/client/core/contents/android/blimp_contents_jni_registrar.cc

index 0b9076fc2ae5654bf891b2276c313ac80cda9be4..bc5bcfc91ddf941a561467b8d343edbbd1e507a2 100644

--- a/blimp/client/core/contents/android/blimp_contents_jni_registrar.cc

+++ b/blimp/client/core/contents/android/blimp_contents_jni_registrar.cc

@@ -5,7 +5,6 @@

#include "blimp/client/core/contents/android/blimp_contents_jni_registrar.h"

#include "base/android/jni_registrar.h"

-#include "blimp/client/core/contents/android/blimp_contents_factory.h"

#include "blimp/client/core/contents/android/blimp_contents_impl_android.h"

#include "blimp/client/core/contents/android/blimp_contents_observer_proxy.h"

#include "blimp/client/core/contents/android/blimp_navigation_controller_impl_android.h"

@@ -15,7 +14,6 @@ namespace client {

namespace {

base::android::RegistrationMethod kBlimpRegistrationMethods[] = {

- {"BlimpContentsFactory", RegisterBlimpContentsFactoryJni},

{"BlimpContentsImplAndroid", BlimpContentsImplAndroid::RegisterJni},

{"BlimpContentsObserverProxy", BlimpContentsObserverProxy::RegisterJni},

{"BlimpNavigationControllerImplAndroid",