blimp/client/core/contents/BUILD.gn - Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/BUILD.gn

Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass TabControlFeature* to BlimpContentsImpl's constructor, remove blimp contents factory Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/contents/BUILD.gn

diff --git a/blimp/client/core/contents/BUILD.gn b/blimp/client/core/contents/BUILD.gn

index e5f57fb4b1afc98f990d3051fd9431e044378bb5..cac01af1834010360d8ae1635a53c12c0375021c 100644

--- a/blimp/client/core/contents/BUILD.gn

+++ b/blimp/client/core/contents/BUILD.gn

@@ -37,8 +37,6 @@ source_set("contents") {

if (is_android) {

sources += [

- "android/blimp_contents_factory.cc",

- "android/blimp_contents_factory.h",

"android/blimp_contents_impl_android.cc",

"android/blimp_contents_impl_android.h",

"android/blimp_contents_jni_registrar.cc",

@@ -106,7 +104,6 @@ if (is_android) {

visibility = [ "//blimp/client/*" ]

java_files = [

- "android/java/src/org/chromium/blimp/core/contents/BlimpContentsFactory.java",

"android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java",

"android/java/src/org/chromium/blimp/core/contents/BlimpContentsObserverProxy.java",

"android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java",

@@ -122,7 +119,6 @@ if (is_android) {

visibility = [ ":*" ]

sources = [

- "android/java/src/org/chromium/blimp/core/contents/BlimpContentsFactory.java",

"android/java/src/org/chromium/blimp/core/contents/BlimpContentsImpl.java",

"android/java/src/org/chromium/blimp/core/contents/BlimpContentsObserverProxy.java",

"android/java/src/org/chromium/blimp/core/contents/BlimpNavigationControllerImpl.java",