Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3166)

Unified Diff: blimp/client/core/contents/blimp_contents_impl.h

Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync to head Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/contents/BUILD.gn ('k') | blimp/client/core/contents/blimp_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/contents/blimp_contents_impl.h
diff --git a/blimp/client/core/contents/blimp_contents_impl.h b/blimp/client/core/contents/blimp_contents_impl.h
index 1110ccde6761bcdddd12dd9fc5bad20774843d16..d39d248f1afd4227e3a6e2ce499e5fdd48326932 100644
--- a/blimp/client/core/contents/blimp_contents_impl.h
+++ b/blimp/client/core/contents/blimp_contents_impl.h
@@ -10,6 +10,7 @@
#include "blimp/client/core/contents/blimp_navigation_controller_delegate.h"
#include "blimp/client/core/contents/blimp_navigation_controller_impl.h"
#include "blimp/client/public/contents/blimp_contents.h"
+#include "ui/gfx/geometry/size.h"
#include "url/gurl.h"
#if defined(OS_ANDROID)
@@ -25,11 +26,12 @@ class BlimpContentsImplAndroid;
class BlimpContentsObserver;
class BlimpNavigationController;
+class TabControlFeature;
class BlimpContentsImpl : public BlimpContents,
public BlimpNavigationControllerDelegate {
public:
- explicit BlimpContentsImpl(int id);
+ explicit BlimpContentsImpl(int id, TabControlFeature* tab_control_feature);
~BlimpContentsImpl() override;
#if defined(OS_ANDROID)
@@ -48,6 +50,10 @@ class BlimpContentsImpl : public BlimpContents,
// BlimpNavigationControllerDelegate implementation.
void OnNavigationStateChanged() override;
+ // Pushes the size and scale information to the engine, which will affect the
+ // web content display area for all tabs.
+ void SetSizeAndScale(const gfx::Size& size, float device_pixel_ratio);
+
int id() { return id_; }
private:
@@ -61,6 +67,12 @@ class BlimpContentsImpl : public BlimpContents,
// BlimpContentsManager to control the life time of the its observer.
int id_;
+ // The tab control feature through which the BlimpContentsImpl is able to
+ // set size and scale.
+ // TODO(mlliu): in the long term, we want to put size and scale in a different
+ // feature instead of tab control feature. crbug.com/639154.
+ TabControlFeature* tab_control_feature_ = nullptr;
+
DISALLOW_COPY_AND_ASSIGN(BlimpContentsImpl);
};
« no previous file with comments | « blimp/client/core/contents/BUILD.gn ('k') | blimp/client/core/contents/blimp_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698