Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: blimp/client/core/android/blimp_client_context_impl_android.cc

Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/android/blimp_client_context_impl_android.cc
diff --git a/blimp/client/core/android/blimp_client_context_impl_android.cc b/blimp/client/core/android/blimp_client_context_impl_android.cc
index 3eb10d66189bd6ccb8cb03a5b34218d005df9366..f6f9a8bfbb054ccb4e914682b00214ec2ba3d3d4 100644
--- a/blimp/client/core/android/blimp_client_context_impl_android.cc
+++ b/blimp/client/core/android/blimp_client_context_impl_android.cc
@@ -14,6 +14,10 @@
namespace blimp {
namespace client {
+namespace {
+const int kDummyTabId = 0;
+}
+
// static
bool BlimpClientContextImplAndroid::RegisterJni(JNIEnv* env) {
return RegisterNativesImpl(env);
@@ -48,6 +52,10 @@ BlimpClientContextImplAndroid::BlimpClientContextImplAndroid(
java_obj_.Reset(env, Java_BlimpClientContextImpl_create(
env, reinterpret_cast<intptr_t>(this))
.obj());
+
+ // Create a single tab's WebContents.
+ // TODO(kmarshall): Remove this once we add tab-literacy to Blimp.
+ GetTabControlFeature()->CreateTab(kDummyTabId);
nyquist 2016/08/16 20:41:04 Could this be in the cross-platform code?
Menglin 2016/08/16 21:10:08 you mean BlimpClientContextImpl? I think so. I add
nyquist 2016/08/16 21:41:40 Right, but I don't think that class is necessarily
Menglin 2016/08/17 19:48:46 Done.
}
BlimpClientContextImplAndroid::~BlimpClientContextImplAndroid() {
« no previous file with comments | « no previous file | blimp/client/core/blimp_client_context_impl.h » ('j') | blimp/client/core/blimp_client_context_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698