Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: blimp/client/core/contents/blimp_contents_impl_unittest.cc

Issue 2255533002: Add TabControlFeature to BlimpClientContextImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass TabControlFeature* to BlimpContentsImpl's constructor, remove blimp contents factory Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/core/contents/blimp_contents_impl.h" 5 #include "blimp/client/core/contents/blimp_contents_impl.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "blimp/client/core/contents/blimp_contents_impl.h" 8 #include "blimp/client/core/contents/blimp_contents_impl.h"
9 #include "blimp/client/core/contents/fake_navigation_feature.h" 9 #include "blimp/client/core/contents/fake_navigation_feature.h"
10 #include "blimp/client/public/contents/blimp_contents_observer.h" 10 #include "blimp/client/public/contents/blimp_contents_observer.h"
(...skipping 15 matching lines...) Expand all
26 ~MockBlimpContentsObserver() override = default; 26 ~MockBlimpContentsObserver() override = default;
27 27
28 MOCK_METHOD0(OnNavigationStateChanged, void()); 28 MOCK_METHOD0(OnNavigationStateChanged, void());
29 29
30 private: 30 private:
31 DISALLOW_COPY_AND_ASSIGN(MockBlimpContentsObserver); 31 DISALLOW_COPY_AND_ASSIGN(MockBlimpContentsObserver);
32 }; 32 };
33 33
34 TEST(BlimpContentsImplTest, LoadURLAndNotifyObservers) { 34 TEST(BlimpContentsImplTest, LoadURLAndNotifyObservers) {
35 base::MessageLoop loop; 35 base::MessageLoop loop;
36 BlimpContentsImpl blimp_contents(kDummyTabId); 36 BlimpContentsImpl blimp_contents(kDummyTabId, nullptr);
37 37
38 BlimpNavigationControllerImpl& navigation_controller = 38 BlimpNavigationControllerImpl& navigation_controller =
39 blimp_contents.GetNavigationController(); 39 blimp_contents.GetNavigationController();
40 FakeNavigationFeature feature; 40 FakeNavigationFeature feature;
41 feature.SetDelegate(1, &navigation_controller); 41 feature.SetDelegate(1, &navigation_controller);
42 navigation_controller.SetNavigationFeatureForTesting(&feature); 42 navigation_controller.SetNavigationFeatureForTesting(&feature);
43 43
44 testing::StrictMock<MockBlimpContentsObserver> observer1(&blimp_contents); 44 testing::StrictMock<MockBlimpContentsObserver> observer1(&blimp_contents);
45 testing::StrictMock<MockBlimpContentsObserver> observer2(&blimp_contents); 45 testing::StrictMock<MockBlimpContentsObserver> observer2(&blimp_contents);
46 46
(...skipping 10 matching lines...) Expand all
57 57
58 navigation_controller.LoadURL(GURL(kOtherExampleURL)); 58 navigation_controller.LoadURL(GURL(kOtherExampleURL));
59 loop.RunUntilIdle(); 59 loop.RunUntilIdle();
60 60
61 EXPECT_EQ(kOtherExampleURL, navigation_controller.GetURL().spec()); 61 EXPECT_EQ(kOtherExampleURL, navigation_controller.GetURL().spec());
62 } 62 }
63 63
64 } // namespace 64 } // namespace
65 } // namespace client 65 } // namespace client
66 } // namespace blimp 66 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698