Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2255493002: Video Capture Mojo (1.4a.b): Rename interface VideoCaptureDevice to VideoCaptureDeviceProxy (Closed)

Created:
4 years, 4 months ago by chfremer
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@FillServicePart1_Part1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Video Capture Mojo: Rename interface VideoCaptureDevice to VideoCaptureDeviceProxy This CL is part of the Mojo Video Capture work. For the bigger picture, see [1]. This is a follow up to a CL [2] currently under review. * Rename interface VideoCaptureDevice to VideoCaptureDeviceProxy. * Rename method VideoCaptureDeviceFactory::CreateDevice() to CreateDeviceProxy(). BUG=584797 TEST=No changes other than rename. Tests still pass. [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing [2] https://codereview.chromium.org/2244763002/ Committed: https://crrev.com/0f27cfe9c7632a6f09888599198f1219c8b1e7bd Cr-Commit-Position: refs/heads/master@{#415022}

Patch Set 1 #

Patch Set 2 : Merge-in changes from upstream CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -99 lines) Patch
M services/video_capture/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/video_capture/public/interfaces/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
D services/video_capture/public/interfaces/video_capture_device.mojom View 1 chunk +0 lines, -30 lines 0 comments Download
M services/video_capture/public/interfaces/video_capture_device_factory.mojom View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/video_capture/public/interfaces/video_capture_device_proxy.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/video_capture/video_capture_device_factory_impl.h View 1 5 chunks +8 lines, -7 lines 0 comments Download
M services/video_capture/video_capture_device_factory_impl.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
D services/video_capture/video_capture_device_impl.h View 1 1 chunk +0 lines, -25 lines 0 comments Download
D services/video_capture/video_capture_device_impl.cc View 1 chunk +0 lines, -18 lines 0 comments Download
A + services/video_capture/video_capture_device_proxy_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + services/video_capture/video_capture_device_proxy_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/video_capture/video_capture_service.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (12 generated)
chfremer
mcasas@: PTAL emircan@, rockot@: FYI
4 years, 4 months ago (2016-08-16 16:57:04 UTC) #3
mcasas
rename lgtm
4 years, 4 months ago (2016-08-16 17:14:49 UTC) #5
chfremer
tsepez@: PTAL *.mojom
4 years, 4 months ago (2016-08-19 16:21:51 UTC) #7
Ken Rockot(use gerrit already)
Seems fine, just one drive-by nitty nit: What does "1.4a.b" mean? Perhaps you don't need ...
4 years, 4 months ago (2016-08-19 17:22:37 UTC) #8
chfremer
On 2016/08/19 17:22:37, Ken Rockot wrote: > Seems fine, just one drive-by nitty nit: What ...
4 years, 4 months ago (2016-08-19 17:27:10 UTC) #9
Tom Sepez
lgtm
4 years, 4 months ago (2016-08-19 17:34:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255493002/20001
4 years, 3 months ago (2016-08-29 15:46:15 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-29 17:27:24 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 17:27:43 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f27cfe9c7632a6f09888599198f1219c8b1e7bd
Cr-Commit-Position: refs/heads/master@{#415022}

Powered by Google App Engine
This is Rietveld 408576698