test-results: Add revisions handler

go/src/infra/appengine/test-results/frontend/revision_test.go

+package frontend
+
+import (
+        "net/http"
+        "net/http/httptest"
+        "testing"
+
+        "golang.org/x/net/context"
+
+        "github.com/luci/luci-go/server/router"
+        . "github.com/smartystreets/goconvey/convey"
+)
+
+func TestCommitPositionToHash(t *testing.T) {
+        t.Parallel()
+
+        data := map[string][]byte{
+                "1300": []byte(`{
+ "git_sha": "0dfc81bbe403cd98f4cd2d58e7817cdc8a881a5f",
+"repo": "chromium/src",
+"redirect_url": "https://chromium.googlesource.com/chromium/src/+/0dfc81bbe403cd98f4cd2d58e7817cdc8a881a5f",
+"project": "chromium",
+"redirect_type": "GIT_FROM_NUMBER",
+"repo_url": "https://chromium.googlesource.com/chromium/src/",
+"kind": "crrev#redirectItem",
+"etag": "\"kuKkspxlsT40mYsjSiqyueMe20E/qt8_sNqlQbK8xP9pkpc9EOsNyrE\""
+}`),
+        }
+        handler := func(c *router.Context) {
+                b, ok := data[c.Params.ByName("pos")]
+                if !ok {
+                        http.Error(c.Writer, "not found", http.StatusNotFound)
+                        return
+                }
+                c.Writer.Write(b)
+        }
+        r := router.New()
+        r.GET("/:pos", router.MiddlewareChain{}, handler)
+
+        srv := httptest.NewServer(r)
+
+        crRevURL = srv.URL
+        makeCrRevClient = func(_ context.Context) *http.Client {
+                return &http.Client{}
+        }
+
+        Convey("commitPositionToHash", t, func() {
+                Convey("existing position", func() {
+                        hash, err := commitPositionToHash(context.Background(), "1300")
+                        So(err, ShouldBeNil)
+                        So(hash, ShouldEqual, "0dfc81bbe403cd98f4cd2d58e7817cdc8a881a5f")
+                })
+
+                Convey("non-existent position", func() {
+                        _, err := commitPositionToHash(context.Background(), "0")
+                        So(err, ShouldNotBeNil)
+                })
+        })
+}