Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8644)

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc

Issue 2255413002: [Signin Error Dialog] (3/3) Added the triggering code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Broke down the CL Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
diff --git a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
index d85e39091424b0a2fbec5c6b34b98025da167fce..8d3c25a74ba0538213a6d06dd209c514a4b57595 100644
--- a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
+++ b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
@@ -25,6 +25,7 @@ const int kPasswordCombinedFixedGaiaViewWidth = 360;
const int kFixedGaiaViewHeight = 612;
const int kModalDialogWidth = 448;
const int kSyncConfirmationDialogHeight = 487;
+const int kSigninErrorDialogHeight = 164;
SigninViewControllerDelegateViews::SigninViewControllerDelegateViews(
SigninViewController* signin_view_controller,
@@ -153,6 +154,21 @@ SigninViewControllerDelegateViews::CreateSyncConfirmationWebView(
return web_view;
}
+views::WebView* SigninViewControllerDelegateViews::CreateSigninErrorWebView(
+ Browser* browser) {
+ views::WebView* web_view = new views::WebView(browser->profile());
+ web_view->LoadInitialURL(GURL(chrome::kChromeUISigninErrorURL));
+
+ int max_height = browser->window()
+ ->GetWebContentsModalDialogHost()
+ ->GetMaximumDialogSize()
+ .height();
+ web_view->SetPreferredSize(gfx::Size(
+ kModalDialogWidth, std::min(kSigninErrorDialogHeight, max_height)));
+
+ return web_view;
+}
+
SigninViewControllerDelegate*
SigninViewControllerDelegate::CreateModalSigninDelegate(
SigninViewController* signin_view_controller,
@@ -175,3 +191,13 @@ SigninViewControllerDelegate::CreateSyncConfirmationDelegate(
SigninViewControllerDelegateViews::CreateSyncConfirmationWebView(browser),
browser, true);
}
+
+SigninViewControllerDelegate*
+SigninViewControllerDelegate::CreateSigninErrorDelegate(
+ SigninViewController* signin_view_controller,
+ Browser* browser) {
+ return new SigninViewControllerDelegateViews(
+ signin_view_controller,
+ SigninViewControllerDelegateViews::CreateSigninErrorWebView(browser),
+ browser, true);
+}

Powered by Google App Engine
This is Rietveld 408576698