[Signin Error Dialog] (3/3) Added the triggering code

chrome/browser/ui/webui/signin/login_ui_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
 
 #include "build/build_config.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 47 matching lines @@
 #if defined(OS_CHROMEOS)
   NOTREACHED();
 #else
   chrome::ScopedTabbedBrowserDisplayer displayer(profile_);
   chrome::ShowBrowserSignin(
       displayer.browser(),
       signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
 #endif
 }
 
+void LoginUIService::SetLastLoginErrorEmail(const base::string16& email) {
+  last_login_error_email_ = email;
+}
+
 void LoginUIService::DisplayLoginResult(Browser* browser,
                                         const base::string16& message) {
 #if defined(OS_CHROMEOS)
   // ChromeOS doesn't have the avatar bubble so it never calls this function.
   NOTREACHED();
 #endif
   last_login_result_ = message;
-  browser->window()->ShowAvatarBubbleFromAvatarButton(
-      message.empty() ? BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN
-                      : BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR,
-      signin::ManageAccountsParams(),
-      signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
+  if (switches::IsMaterialDesignUserMenu() && !message.empty()) {
+    browser->ShowModalSigninErrorWindow();

[tommycli, 2016/08/23 19:15:39]

Knowing little about signin, this confuses me. It should show the error window
when there's a login result?

Is |message| always an error message? If so, we should rename the variable

[Jane, 2016/08/24 13:40:31]

Done. You are right, this is confusing. Somewhere buried deep it would say that
empty message means signin success, otherwise it's an error. I renamed it to be
error_message.

+  } else {
+    browser->window()->ShowAvatarBubbleFromAvatarButton(
+        message.empty() ? BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN
+                        : BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR,
+        signin::ManageAccountsParams(),
+        signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
+  }
 }
 
 const base::string16& LoginUIService::GetLastLoginResult() {
   return last_login_result_;
 }
+
+const base::string16& LoginUIService::GetLastLoginErrorEmail() {
+  return last_login_error_email_;
+}