[Signin Error Dialog] (3/3) Added the triggering code

chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/signin/inline_login_handler_impl.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
@@ skipping 436 matching lines @@
       }
       break;
     default:
       DCHECK(false) << "Invalid action";
   }
   base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
 }
 
 void InlineSigninHelper::OnClientOAuthFailure(
   const GoogleServiceAuthError& error) {
+  LoginUIServiceFactory::GetForProfile(profile_)->SetLastLoginErrorEmail(
+      base::string16());
   if (handler_)
     handler_->HandleLoginError(error.ToString());
 
   AboutSigninInternals* about_signin_internals =
     AboutSigninInternalsFactory::GetForProfile(profile_);
   about_signin_internals->OnRefreshTokenReceived("Failure");
 
   base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
 }
 
@@ skipping 306 matching lines @@
   // gaia sign in page, but signs in to a different account in the SAML sign in
   // page.
   std::string default_email;
   std::string validate_email;
   if (net::GetValueForKeyInQuery(params.url, "email", &default_email) &&
       net::GetValueForKeyInQuery(params.url, "validateEmail",
                                  &validate_email) &&
       validate_email == "1") {
     if (!gaia::AreEmailsSame(params.email, default_email)) {
       if (params.handler) {
+        LoginUIServiceFactory::GetForProfile(profile)->SetLastLoginErrorEmail(
+            base::UTF8ToUTF16(params.email));
         params.handler->HandleLoginError(
             l10n_util::GetStringFUTF8(IDS_SYNC_WRONG_EMAIL,
                                       base::UTF8ToUTF16(default_email)));
       }
       return;
     }
   }
 
   signin_metrics::AccessPoint access_point =
       signin::GetAccessPointForPromoURL(params.url);
@@ skipping 24 matching lines @@
     }
     default:
       // No need to change |can_offer_for|.
       break;
   }
 
   std::string error_msg;
   bool can_offer = CanOffer(profile, can_offer_for, params.gaia_id,
                             params.email, &error_msg);
   if (!can_offer) {
-    if (params.handler)
+    if (params.handler) {
+      LoginUIServiceFactory::GetForProfile(profile)->SetLastLoginErrorEmail(
+          base::UTF8ToUTF16(params.email));
       params.handler->HandleLoginError(error_msg);

[tommycli, 2016/08/23 19:15:39]

Instead of setting a global SetLastLoginErrorEmail, we should pass it along the
same lines as error_msg.

[Jane, 2016/08/24 13:40:31]

Done.

+    }
     return;
   }
 
   AboutSigninInternals* about_signin_internals =
       AboutSigninInternalsFactory::GetForProfile(profile);
   about_signin_internals->OnAuthenticationResultReceived("Successful");
 
   SigninClient* signin_client =
       ChromeSigninClientFactory::GetForProfile(profile);
   std::string signin_scoped_device_id =
@@ skipping 94 matching lines @@
     }
 
     if (show_account_management) {
       browser->window()->ShowAvatarBubbleFromAvatarButton(
           BrowserWindow::AVATAR_BUBBLE_MODE_ACCOUNT_MANAGEMENT,
           signin::ManageAccountsParams(),
           signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);
     }
   }
 }