chrome/browser/resources/signin_error/signin_error.html - Issue 2255413002: [Signin Error Dialog] (3/3) Added the triggering code

Side by Side Diff: chrome/browser/resources/signin_error/signin_error.html

Issue 2255413002: [Signin Error Dialog] (3/3) Added the triggering code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: anthonyvd's first pass Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/signin_error/signin_error.css ('K') | « chrome/browser/resources/signin_error/signin_error.css ('k') | chrome/browser/resources/signin_error/signin_error.js » ('j') | chrome/browser/resources/signin_error/signin_error.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html i18n-values="dir:textdirection;lang:language">

	3 <head>

	4 <meta charset="utf-8">

	5 <link rel="import" href="chrome://resources/html/polymer.html">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper- button.html">

	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color. html">

	8 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

	9 <link rel="stylesheet" href="signin_error.css"></link>
	tommycli 2016/08/23 19:15:39 If that CSS file is only used in here, why not jus If that CSS file is only used in here, why not just combine it below? Also I think external stylesheets are deprecated: https://www.polymer-project.org/1.0/docs/devguide/styling#external-stylesheets Jane 2016/08/24 13:40:31 Done. Show quoted text On 2016/08/23 19:15:39, tommycli wrote: > If that CSS file is only used in here, why not just combine it below? > > Also I think external stylesheets are deprecated: > https://www.polymer-project.org/1.0/docs/devguide/styling#external-stylesheets Done.
	10 <style is="custom-style">

	11 a {

	12 color: var(--google-blue-700);

	13 text-decoration: none;

	14 }

	15

	16 paper-button.primary-action {

	17 background: var(--google-blue-500);

	18 color: white;

	19 font-weight: 500;
	tommycli 2016/08/23 19:15:39 These styles that are in common with both primary These styles that are in common with both primary and secondary can be just put in a paper-button selector Jane 2016/08/24 13:40:31 Done. Show quoted text On 2016/08/23 19:15:39, tommycli wrote: > These styles that are in common with both primary and secondary can be just put > in a paper-button selector Done.
	20 --paper-button-flat-keyboard-focus: {

	21 background: rgb(58, 117, 215);

	22 };

	23 }

	24

	25 paper-button.secondary-action {

	26 color: var(--google-blue-500);

	27 font-weight: 500;

	28 --paper-button-flat-keyboard-focus: {

	29 background: rgba(0, 0, 0, .12);

	30 };

	31 }

	32

	33 <if expr="is_macosx or is_linux">

	34 .action-container {

	35 flex-flow: row-reverse;

	36 justify-content: flex-start;

	37 }

	38 </if>

	39 </style>

	40 </head>

	41 <body>

	42 <div class="container">

	43 <div class="top-title-bar">$i18n{signinErrorTitle}</div>

	44 <div class="details" i18n-values=".innerHTML:signinErrorMessage"></div>
	tommycli 2016/08/23 19:15:39 does using $i18nRaw work? does using $i18nRaw work? Jane 2016/08/24 13:40:31 Done. Yep! Show quoted text On 2016/08/23 19:15:39, tommycli wrote: > does using $i18nRaw work? Done. Yep!
	45 <div class="action-container">

	46 <paper-button class="primary-action" id="switchButton">

	47 $i18n{signinErrorSwitchLabel}

	48 </paper-button>

	49 <paper-button class="secondary-action" id="secondaryConfirmButton">

	50 $i18n{signinErrorOkLabel}

	51 </paper-button>

	52 <paper-button class="primary-action" id="primaryConfirmButton">

	53 $i18n{signinErrorOkLabel}

	54 </paper-button>

	55 </div>

	56 </div>

	57 </body>

	58 <script src="chrome://resources/js/cr.js"></script>

	59 <script src="chrome://resources/js/load_time_data.js"></script>

	60 <script src="chrome://resources/js/util.js"></script>

	61 <script src="signin_error.js"></script>

	62 <script src="chrome://signin-error/strings.js"></script>

	63 <script src="chrome://resources/js/i18n_template.js"></script>

	64 </html>

OLD	NEW