Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 22554002: Pacify Win7 builders (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/zone.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL. This should fix: ...\v8\src\effects.h(199): warning C4291: 'void *v8::internal::ZoneSplayTree<Config>::operator new(size_t,v8::internal::Zone *)' : no matching operator ...
7 years, 4 months ago (2013-08-07 08:17:10 UTC) #1
Sven Panne
LGTM (and pray ;-)
7 years, 4 months ago (2013-08-07 08:25:18 UTC) #2
Jakob Kummerow
7 years, 4 months ago (2013-08-07 08:25:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16088 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698