Allow a foreign fetch event handler to not handle an event.

Allow a foreign fetch event handler to not handle an event.

Previously when a foreign fetch event handler decided not to handle an
event that would be considered a failure, as bouncing the request back
through the renderer (as would be necesary in the case of a cross origin
request to a regular service worker's fetch event) doesn't work for
foreign fetch. But since all the CORS logic is still in place for requests
that are intercepted by foreign fetch (and in particular requests with
preflights can't be intercepted by foreign fetch) it is always safe to
fall back to the network directly rather than falling back to the
renderer for foreign fetch requests.

BUG=604084
Committed: https://crrev.com/976f647c1325d73b120e234289ee9d7ef0973767
Cr-Commit-Position: refs/heads/master@{#413525}

[Marijn Kruisselbrink, 2016-08-18 22:01:19]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 22:02:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2016-08-18 23:15:33]

mek@chromium.org changed reviewers:
+ horo@chromium.org

[commit-bot: I haz the power, 2016-08-19 01:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 01:52:47]

Dry run: This issue passed the CQ dry run.

[horo, 2016-08-21 07:42:24]

lgtm with a nit.

https://codereview.chromium.org/2255383002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_url_request_job.cc (left):

https://codereview.chromium.org/2255383002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_url_request_job.cc:264: //
TODO(shimazu): Remove the condition of FOREIGN_FETCH after figuring out
Nit: I think this comment is not appropriate here. This method is called only
from ServiceWorkerControlleeRequestHandler. Please remove it.

[Marijn Kruisselbrink, 2016-08-22 16:48:14]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 16:48:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2016-08-22 16:52:16]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2016-08-22 16:52:18]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2016-08-22 16:52:18]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org
Link to the patchset: https://codereview.chromium.org/2255383002/#ps20001
(title: "Remove comment from FallbackToNetworkOrRenderer")

[commit-bot: I haz the power, 2016-08-22 16:52:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 19:13:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 19:13:08]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Marijn Kruisselbrink, 2016-08-22 19:15:58]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-08-22 19:16:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 20:36:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-22 20:38:30]

Description was changed from

==========
Allow a foreign fetch event handler to not handle an event.

Previously when a foreign fetch event handler decided not to handle an
event that would be considered a failure, as bouncing the request back
through the renderer (as would be necesary in the case of a cross origin
request to a regular service worker's fetch event) doesn't work for
foreign fetch. But since all the CORS logic is still in place for requests
that are intercepted by foreign fetch (and in particular requests with
preflights can't be intercepted by foreign fetch) it is always safe to
fall back to the network directly rather than falling back to the
renderer for foreign fetch requests.

BUG=604084
==========

to

==========
Allow a foreign fetch event handler to not handle an event.

Previously when a foreign fetch event handler decided not to handle an
event that would be considered a failure, as bouncing the request back
through the renderer (as would be necesary in the case of a cross origin
request to a regular service worker's fetch event) doesn't work for
foreign fetch. But since all the CORS logic is still in place for requests
that are intercepted by foreign fetch (and in particular requests with
preflights can't be intercepted by foreign fetch) it is always safe to
fall back to the network directly rather than falling back to the
renderer for foreign fetch requests.

BUG=604084

Committed: https://crrev.com/976f647c1325d73b120e234289ee9d7ef0973767
Cr-Commit-Position: refs/heads/master@{#413525}
==========

[commit-bot: I haz the power, 2016-08-22 20:38:31]

Patchset 2 (id:??) landed as
https://crrev.com/976f647c1325d73b120e234289ee9d7ef0973767
Cr-Commit-Position: refs/heads/master@{#413525}