Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2255363002: TextInputManager::GetTextSelection() should be called on focused widget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check for focused widget before using its view Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 87ee275d354b0c58e840da23fed57026dc133883..2ccddb24be0181e797ce68c28eed90738c45ed3b 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -4494,7 +4494,8 @@ TEST_F(InputMethodStateAuraTest, GetSelectedText) {
gfx::Range selection_range(20, 21);
for (auto index : active_view_sequence_) {
- ActivateViewForTextInputManager(views_[index], ui::TEXT_INPUT_TYPE_TEXT);
+ render_widget_host_delegate()->set_focused_widget(
+ RenderWidgetHostImpl::From(views_[index]->GetRenderWidgetHost()));
views_[index]->SelectionChanged(text, offset, selection_range);
base::string16 expected_text = text.substr(
selection_range.GetMin() - offset, selection_range.length());
@@ -4514,7 +4515,8 @@ TEST_F(InputMethodStateAuraTest, GetTextRange) {
gfx::Range selection_range;
for (auto index : active_view_sequence_) {
- ActivateViewForTextInputManager(views_[index], ui::TEXT_INPUT_TYPE_TEXT);
+ render_widget_host_delegate()->set_focused_widget(
+ RenderWidgetHostImpl::From(views_[index]->GetRenderWidgetHost()));
gfx::Range expected_range(offset, offset + text.length());
views_[index]->SelectionChanged(text, offset, selection_range);
gfx::Range range_from_client;
@@ -4535,7 +4537,8 @@ TEST_F(InputMethodStateAuraTest, GetSelectionRange) {
gfx::Range expected_range(0U, 1U);
for (auto index : active_view_sequence_) {
- ActivateViewForTextInputManager(views_[index], ui::TEXT_INPUT_TYPE_TEXT);
+ render_widget_host_delegate()->set_focused_widget(
+ RenderWidgetHostImpl::From(views_[index]->GetRenderWidgetHost()));
views_[index]->SelectionChanged(text, 0U, expected_range);
gfx::Range range_from_client;
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698