Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2255333002: Revert of Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. (Closed)

Created:
4 years, 4 months ago by benzh
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. (patchset #1 id:1 of https://codereview.chromium.org/2250303004/ ) Reason for revert: Broke falco-full-compile-paladin crbug.com/638980 Original issue's description: > Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server metrics. > > This is the 4th time I've landed this change and I have become exceedingly efficient at it. > > BUG=620610 > TBR=sergeyberezin > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/bdec453c0416ab58df8cbebad831345caa729553 TBR=sergeyberezin@chromium.org,dsansome@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=620610 Committed: https://chromium.googlesource.com/chromium/tools/build/+/fe8bc0faaaafd8c083feeffee4d7629a68fae990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -101 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M masters/buildbot.tac View 1 chunk +1 line, -24 lines 0 comments Download
M scripts/master/master_utils.py View 2 chunks +1 line, -3 lines 0 comments Download
D scripts/master/monitoring_status_receiver.py View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/buildbot_8_4p1/buildbot/status/web/baseweb.py View 3 chunks +2 lines, -32 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
benzh
Created Revert of Re-land "Make Buildbot masters send ts_mon metrics, and add standard HTTP server ...
4 years, 4 months ago (2016-08-18 19:50:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255333002/1
4 years, 4 months ago (2016-08-18 19:50:34 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-18 19:50:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255333002/1
4 years, 4 months ago (2016-08-18 19:55:54 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-18 19:55:56 UTC) #9
sosa1
lgtm
4 years, 4 months ago (2016-08-18 20:18:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255333002/1
4 years, 4 months ago (2016-08-18 20:19:13 UTC) #13
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-18 20:19:15 UTC) #15
sosa
lgtm Weird I am in that committers list. Maybe from my chromium account?
4 years, 4 months ago (2016-08-18 20:20:20 UTC) #17
sosa
lgtm lgtm Weird I am in that committers list. Maybe from my chromium account?
4 years, 4 months ago (2016-08-18 20:20:21 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255333002/1
4 years, 4 months ago (2016-08-18 20:20:42 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 20:20:53 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/fe8bc0faaaafd8c083fe...

Powered by Google App Engine
This is Rietveld 408576698