third_party/WebKit/Source/core/input/KeyboardEventManager.h - Issue 2255323004: Create MouseEventManager and EventHandlingUtil

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/KeyboardEventManager.h

Issue 2255323004: Create MouseEventManager and EventHandlingUtil (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make all *Manager classes GarbageCollected Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/KeyboardEventManager.h

diff --git a/third_party/WebKit/Source/core/input/KeyboardEventManager.h b/third_party/WebKit/Source/core/input/KeyboardEventManager.h

index 3ee80f33d3b7ff67d3be146b3094c052446059fa..112ba67ca13f349622852c494856299f13714f34 100644

--- a/third_party/WebKit/Source/core/input/KeyboardEventManager.h

+++ b/third_party/WebKit/Source/core/input/KeyboardEventManager.h

@@ -26,9 +26,8 @@ enum class OverrideCapsLockState {

Off

};

-class CORE_EXPORT KeyboardEventManager {

+class CORE_EXPORT KeyboardEventManager final : public GarbageCollectedFinalized<KeyboardEventManager> {

haraken 2016/09/01 23:31:15 Ditto. Drop 'Finalized'.

Navid Zolghadr 2016/09/02 16:36:45 Done.

WTF_MAKE_NONCOPYABLE(KeyboardEventManager);

- DISALLOW_NEW();

public:

static const int kAccessKeyModifiers =

// TODO(crbug.com/618397): Add a settings to control this behavior.

@@ -63,7 +62,7 @@ private:

const Member<LocalFrame> m_frame;

- ScrollManager* m_scrollManager;

+ Member<ScrollManager> m_scrollManager;

};

} // namespace blink