Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 2255313006: [turbofan] Inline construct calls to CPP builtins (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Base URL:
https://chromium.googlesource.com/v8/v8.git@inline-cpp-builtins-cleanup
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline construct calls to CPP builtins BUG= Committed: https://crrev.com/6d51bab3d227bdc1d0910776fcd5b3f72948da02 Cr-Commit-Position: refs/heads/master@{#38783}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -61 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 2 4 chunks +109 lines, -61 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
jgruber
I wish this could be a bit cleaner, without all the crazy arity arithmetic. Let ...
4 years, 4 months ago (2016-08-19 16:05:53 UTC) #8
Jarin
lgtm
4 years, 4 months ago (2016-08-22 12:17:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255313006/40001
4 years, 4 months ago (2016-08-22 12:26:40 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-22 12:57:45 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 12:58:05 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6d51bab3d227bdc1d0910776fcd5b3f72948da02
Cr-Commit-Position: refs/heads/master@{#38783}

Powered by Google App Engine
This is Rietveld 408576698