Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4364)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2255313004: Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: don't change the compiler lol Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index e0896b097faf8f623e0ab52116a4fa38167c3103..14f385106a9e1eb70e3f90c28fe423d315abd661 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -237,15 +237,9 @@ void PaintDetachedBookmarkBar(gfx::Canvas* canvas,
SkColor separator_color =
tp->GetColor(ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR);
- if (ui::MaterialDesignController::IsModeMaterial()) {
- BrowserView::Paint1pxHorizontalLine(
- canvas, separator_color,
- gfx::Rect(0, 0, view->width(),
- views::NonClientFrameView::kClientEdgeThickness),
- true);
- } else {
+ if (!ui::MaterialDesignController::IsModeMaterial()) {
Peter Kasting 2016/08/19 01:32:59 Nit: No {}
Bret 2016/08/19 18:02:00 Done.
PaintHorizontalBorder(canvas, view, true, separator_color);
- }
+ } // In material mode the toolbar bottom stroke serves as our top stroke.
Peter Kasting 2016/08/19 01:32:59 Nit: I'd put this comment above the conditional.
Bret 2016/08/19 18:02:00 Done.
// For the bottom separator, increase the luminance. Either double it or halve
// the distance to 1.0, whichever is less of a difference.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698