Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar.

Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar.

The toolbar draws a 1 pixel line as its bottom border. The detached
bookmark bar also draws a 1 pixel line as its top border. At 1x and 2x
those lines always overlap. But the bookmark bar top stroke was not laid
out properly so at fractional dsfs it would be pushed down 1 pixel and
cause the border to look like it was 2 pixels. I removed the bookmark
bar top stroke since it was redundant anyway.

R=pkasting
BUG=636120
Committed: https://crrev.com/af9ecebdf6e165d4e0742c14bd16ec380124bb91
Cr-Commit-Position: refs/heads/master@{#413211}

[Peter Kasting, 2016-08-19 01:32:58]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2016-08-19 01:32:59]

I think you mean "I removed the bookmark bar top stroke".

LGTM

https://codereview.chromium.org/2255313004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/2255313004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_view.cc:240: if
(!ui::MaterialDesignController::IsModeMaterial()) {
Nit: No {}

https://codereview.chromium.org/2255313004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_view.cc:242: } // In material mode the
toolbar bottom stroke serves as our top stroke.
Nit: I'd put this comment above the conditional.

[Bret, 2016-08-19 17:45:35]

Description was changed from

==========
Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar.

The toolbar draws a 1 pixel line as its bottom border. The detached
bookmark bar also draws a 1 pixel line as its top border. At 1x and 2x
those lines always overlap. But the bookmark bar top stroke was not laid
out properly so at fractional dsfs it would be pushed down 1 pixel and
cause the border to look like it was 2 pixels. I removed the toolbar top
stroke since it was redundant anyway.

R=pkasting
BUG=636120
==========

to

==========
Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar.

The toolbar draws a 1 pixel line as its bottom border. The detached
bookmark bar also draws a 1 pixel line as its top border. At 1x and 2x
those lines always overlap. But the bookmark bar top stroke was not laid
out properly so at fractional dsfs it would be pushed down 1 pixel and
cause the border to look like it was 2 pixels. I removed the bookmark
bar top stroke since it was redundant anyway.

R=pkasting
BUG=636120
==========

[Bret, 2016-08-19 18:02:00]

https://codereview.chromium.org/2255313004/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/2255313004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_view.cc:240: if
(!ui::MaterialDesignController::IsModeMaterial()) {
On 2016/08/19 01:32:59, Peter Kasting wrote:
> Nit: No {}

Done.

https://codereview.chromium.org/2255313004/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_view.cc:242: } // In material mode the
toolbar bottom stroke serves as our top stroke.
On 2016/08/19 01:32:59, Peter Kasting wrote:
> Nit: I'd put this comment above the conditional.

Done.

[Bret, 2016-08-19 18:02:10]

The CQ bit was checked by bsep@chromium.org

[Bret, 2016-08-19 18:02:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2255313004/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2016-08-19 18:03:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 19:36:50]

Description was changed from

==========
Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar.

The toolbar draws a 1 pixel line as its bottom border. The detached
bookmark bar also draws a 1 pixel line as its top border. At 1x and 2x
those lines always overlap. But the bookmark bar top stroke was not laid
out properly so at fractional dsfs it would be pushed down 1 pixel and
cause the border to look like it was 2 pixels. I removed the bookmark
bar top stroke since it was redundant anyway.

R=pkasting
BUG=636120
==========

to

==========
Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar.

The toolbar draws a 1 pixel line as its bottom border. The detached
bookmark bar also draws a 1 pixel line as its top border. At 1x and 2x
those lines always overlap. But the bookmark bar top stroke was not laid
out properly so at fractional dsfs it would be pushed down 1 pixel and
cause the border to look like it was 2 pixels. I removed the bookmark
bar top stroke since it was redundant anyway.

R=pkasting
BUG=636120
==========

[commit-bot: I haz the power, 2016-08-19 19:36:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-19 19:40:58]

Description was changed from

==========
Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar.

The toolbar draws a 1 pixel line as its bottom border. The detached
bookmark bar also draws a 1 pixel line as its top border. At 1x and 2x
those lines always overlap. But the bookmark bar top stroke was not laid
out properly so at fractional dsfs it would be pushed down 1 pixel and
cause the border to look like it was 2 pixels. I removed the bookmark
bar top stroke since it was redundant anyway.

R=pkasting
BUG=636120
==========

to

==========
Fix the toolbar bottom border being 2 pixels w/ a detached bookmark bar.

The toolbar draws a 1 pixel line as its bottom border. The detached
bookmark bar also draws a 1 pixel line as its top border. At 1x and 2x
those lines always overlap. But the bookmark bar top stroke was not laid
out properly so at fractional dsfs it would be pushed down 1 pixel and
cause the border to look like it was 2 pixels. I removed the bookmark
bar top stroke since it was redundant anyway.

R=pkasting
BUG=636120

Committed: https://crrev.com/af9ecebdf6e165d4e0742c14bd16ec380124bb91
Cr-Commit-Position: refs/heads/master@{#413211}
==========

[commit-bot: I haz the power, 2016-08-19 19:40:58]

Patchset 3 (id:??) landed as
https://crrev.com/af9ecebdf6e165d4e0742c14bd16ec380124bb91
Cr-Commit-Position: refs/heads/master@{#413211}