Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2255313002: Revert of Blink-compatible serialization of arrays, both dense and sparse. (Closed)

Created:
4 years, 4 months ago by jbroman
Modified:
4 years, 4 months ago
Reviewers:
adamk, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Blink-compatible serialization of arrays, both dense and sparse. (patchset #6 id:100001 of https://codereview.chromium.org/2259633002/ ) Reason for revert: Broke MIPS compile due to an uninitialization warning: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/3110/steps/compile/logs/stdio Original issue's description: > Blink-compatible serialization of arrays, both dense and sparse. > > The current "dense" format is not expressive enough to distinguish between > an element that is not defined and one that has the value "undefined", > but in this CL the existing behaviour of Blink is used for such cases. > Format changes to fix these issues could be made later on. > > Not included in this CL is compatibility with version 0 arrays. > Those will be implemented in a separate CL. > > BUG=chromium:148757 > > Committed: https://crrev.com/2e000127df2e88e31d352ef70af397741d1f2298 > Cr-Commit-Position: refs/heads/master@{#38729} TBR=jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:148757 Committed: https://crrev.com/255971d3ac113845361eb0122e89ca13a7063dda Cr-Commit-Position: refs/heads/master@{#38730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -477 lines) Patch
M src/value-serializer.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/value-serializer.cc View 5 chunks +0 lines, -142 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +0 lines, -332 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jbroman
Created Revert of Blink-compatible serialization of arrays, both dense and sparse.
4 years, 4 months ago (2016-08-18 18:56:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255313002/1
4 years, 4 months ago (2016-08-18 18:56:49 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-18 18:56:51 UTC) #5
jbroman
adamk, would you mind stamping this revert as a committer? It's a trivial fix, but ...
4 years, 4 months ago (2016-08-18 19:01:29 UTC) #7
adamk
lgtm
4 years, 4 months ago (2016-08-18 19:58:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255313002/1
4 years, 4 months ago (2016-08-18 19:58:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 19:58:40 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 19:58:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/255971d3ac113845361eb0122e89ca13a7063dda
Cr-Commit-Position: refs/heads/master@{#38730}

Powered by Google App Engine
This is Rietveld 408576698