Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1826)

Unified Diff: appengine/findit/handlers/flake/check_flake.py

Issue 2255293003: [Findit] On hover over, shows pass rate for a swarming rerun (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/flake/check_flake.py
diff --git a/appengine/findit/handlers/flake/check_flake.py b/appengine/findit/handlers/flake/check_flake.py
index 84b51ae8029827137450ae9eda01fe3d1eca1335..80d01e0f12ac71883dea571486d59577733041e3 100644
--- a/appengine/findit/handlers/flake/check_flake.py
+++ b/appengine/findit/handlers/flake/check_flake.py
@@ -7,6 +7,7 @@ from google.appengine.api import users
from common import constants
from common.base_handler import BaseHandler
from common.base_handler import Permission
+from model.analysis_status import STATUS_TO_DESCRIPTION
from waterfall.flake.initialize_flake_pipeline import ScheduleAnalysisIfNeeded
@@ -28,11 +29,21 @@ class CheckFlake(BaseHandler):
master_name, builder_name, build_number, step_name,
test_name, force=force, queue_name=constants.WATERFALL_ANALYSIS_QUEUE)
data = {
- 'success_rates': []
+ 'success_rates': [],
+ 'analysis_status': STATUS_TO_DESCRIPTION.get(
+ master_flake_analysis.status),
+ 'suspected_flake_build_number': (
+ master_flake_analysis.suspected_flake_build_number),
+ 'master_name': master_name,
+ 'builder_name': builder_name,
+ 'build_number': build_number,
+ 'step_name': step_name,
+ 'test_name': test_name
}
- for (build_number, success_rate) in zip(
- master_flake_analysis.build_numbers,
- master_flake_analysis.success_rates):
+ zipped = zip(master_flake_analysis.build_numbers,
+ master_flake_analysis.success_rates)
+ zipped.sort(key = lambda x: x[0])
+ for (build_number, success_rate) in zipped:
data['success_rates'].append([build_number, success_rate])
return {
'template': 'flake/result.html',
« no previous file with comments | « no previous file | appengine/findit/templates/flake/result.html » ('j') | appengine/findit/templates/flake/result.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698