Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2255263002: [turbolizer] Also escape backslashes in JSON strings. (Closed)

Created:
4 years, 4 months ago by bgeron
Modified:
4 years, 4 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Also escape backslashes in JSON strings. BUG= Committed: https://crrev.com/21f2eb6c48527d280e30ccbab628b86294e15393 Cr-Commit-Position: refs/heads/master@{#38748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/compiler/graph-visualizer.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bgeron
PTAL.
4 years, 4 months ago (2016-08-18 17:30:28 UTC) #2
Jarin
lgtm
4 years, 4 months ago (2016-08-19 09:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255263002/1
4 years, 4 months ago (2016-08-19 10:31:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 10:54:07 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 10:54:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21f2eb6c48527d280e30ccbab628b86294e15393
Cr-Commit-Position: refs/heads/master@{#38748}

Powered by Google App Engine
This is Rietveld 408576698