Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2255253002: Revert of android: Switch CleanupReference to PhantomReference (Closed)

Created:
4 years, 4 months ago by boliu
Modified:
4 years, 4 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Switch CleanupReference to PhantomReference (patchset #1 id:1 of https://codereview.chromium.org/2241533002/ ) Reason for revert: Experiment out. Reverting. See bug for reasoning. Original issue's description: > android: Switch CleanupReference to PhantomReference > > Again. This time due to correctness. Want to experiment on beta to see > how big the impact is. Quoting from the comment in the CL: > > NOTE Using PhantonReference instead of WeakReference is required for correctness. > WeakReferences are enqueued before finalizers are called, and finalizers can > resurrect the referent object. PhantomReference does delay clean up more compared > to WeakReference. > > BUG=618807 > > Committed: https://crrev.com/630d88124d2e5a3fda6b9fd25d06eaa1af403fca > Cr-Commit-Position: refs/heads/master@{#411417} TBR=dtrainor@chromium.org,yfriedman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618807 Committed: https://crrev.com/74e50f4c229d7b9f895a3108abdd0309395b919c Cr-Commit-Position: refs/heads/master@{#412871}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M content/public/android/java/src/org/chromium/content/common/CleanupReference.java View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
boliu
Created Revert of android: Switch CleanupReference to PhantomReference
4 years, 4 months ago (2016-08-18 16:47:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255253002/1
4 years, 4 months ago (2016-08-18 16:47:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 17:28:32 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 17:30:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74e50f4c229d7b9f895a3108abdd0309395b919c
Cr-Commit-Position: refs/heads/master@{#412871}

Powered by Google App Engine
This is Rietveld 408576698