Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2255223002:
Use the process-level MojoShellConnection to connect to mojo:media. (Closed)
|
Created:
4 years, 4 months ago by slan Modified:
4 years, 4 months ago CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse the process-level MojoShellConnection to connect to mojo:media.
The interface provided by mojo:media, media::mojom::MediaService, is
registered in mojo_shell_context.cc on the browser process
MojoShellConnection. Use this ShellConnection to connect to this
interface (rather than the connection for the BrowserContext).
BUG=638950
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/f78815009d7a7801126d30a76c71a2554ea86f93
Cr-Commit-Position: refs/heads/master@{#412859}
Patch Set 1 #Patch Set 2 : Added comment with bug. #Messages
Total messages: 17 (10 generated)
Description was changed from ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG= Change-Id: I2d72b2f6afe036f738af161f7f88b7854538d541 ========== to ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG= Change-Id: I2d72b2f6afe036f738af161f7f88b7854538d541 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Description was changed from ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG= Change-Id: I2d72b2f6afe036f738af161f7f88b7854538d541 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
slan@chromium.org changed reviewers: + ben@chromium.org, rockot@chromium.org, xhwang@chromium.org
Hey all, This fixes the issue discussed yesterday for mojo:media connections. PTAL.
The CQ bit was checked by slan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
As discussed yesterday, it would be ideal if we supported a media service instance per user, but since this maintains the previous state of the universe and fixes production code, LGTM. Nit: Could you please file a bug to move this to the BrowserContext's Connector, and reference that bug in a TODO here?
lgtm
The CQ bit was checked by slan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org, ben@chromium.org Link to the patchset: https://codereview.chromium.org/2255223002/#ps20001 (title: "Added comment with bug.")
On 2016/08/18 14:50:35, Ken Rockot wrote: > As discussed yesterday, it would be ideal if we supported a media service > instance per user, but since this maintains the previous state of the universe > and fixes production code, LGTM. > > Nit: Could you please file a bug to move this to the BrowserContext's Connector, > and reference that bug in a TODO here? Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG=NONE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG=638950 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Message was sent while issue was closed.
Description was changed from ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG=638950 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG=638950 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG=638950 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Use the process-level MojoShellConnection to connect to mojo:media. The interface provided by mojo:media, media::mojom::MediaService, is registered in mojo_shell_context.cc on the browser process MojoShellConnection. Use this ShellConnection to connect to this interface (rather than the connection for the BrowserContext). BUG=638950 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/f78815009d7a7801126d30a76c71a2554ea86f93 Cr-Commit-Position: refs/heads/master@{#412859} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f78815009d7a7801126d30a76c71a2554ea86f93 Cr-Commit-Position: refs/heads/master@{#412859} |
