Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2255153004: [DevTools] An snprintf shim for old VS compat (Closed)

Created:
4 years, 4 months ago by eostroukhov
Modified:
4 years, 4 months ago
Reviewers:
kozy, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] An snprintf shim for old VS compat BUG= Committed: https://crrev.com/e5f7f49d540a998deef5c2790cf6efa1158f29f1 Cr-Commit-Position: refs/heads/master@{#413158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/PlatformSTL.h View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
eostroukhov-old
4 years, 4 months ago (2016-08-18 23:41:10 UTC) #3
eostroukhov
4 years, 4 months ago (2016-08-18 23:42:06 UTC) #6
dgozman
lgtm
4 years, 4 months ago (2016-08-19 00:09:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255153004/1
4 years, 4 months ago (2016-08-19 16:10:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 16:14:23 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 16:19:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5f7f49d540a998deef5c2790cf6efa1158f29f1
Cr-Commit-Position: refs/heads/master@{#413158}

Powered by Google App Engine
This is Rietveld 408576698