Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2255153002: Reland "[heap] Don't unmap new space pages while sweeping is active" (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Don't unmap new space pages while sweeping is active - Avoid unmapping of new space pages while sweeping using a delayed list that gets emptied upon the next call to the unmapper. BUG=chromium:628984 R=hpayer@chromium.org This reverts commit 4a1f2807d6da046367afd243159e40275ad9f8c6. Committed: https://crrev.com/ece2f1084b97d4b5bffa6a3b3004a45a9366ff94 Cr-Commit-Position: refs/heads/master@{#38715}

Patch Set 1 : base #

Patch Set 2 : Bring back newspace barrier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M src/heap/spaces.h View 3 chunks +13 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Lippautz
we need the new space barrier as this ensure us that all pages in new ...
4 years, 4 months ago (2016-08-18 11:35:52 UTC) #4
Hannes Payer (out of office)
lgtm
4 years, 4 months ago (2016-08-18 11:36:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255153002/40001
4 years, 4 months ago (2016-08-18 11:39:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-18 12:16:40 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 12:17:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ece2f1084b97d4b5bffa6a3b3004a45a9366ff94
Cr-Commit-Position: refs/heads/master@{#38715}

Powered by Google App Engine
This is Rietveld 408576698