Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2630)

Unified Diff: device/hid/hid_service_mac.cc

Issue 225513005: chrome.hid : enrich device info with Top-Level collections usages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: renaming 'parent_item' Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/hid/hid_service_mac.cc
diff --git a/device/hid/hid_service_mac.cc b/device/hid/hid_service_mac.cc
index 3df7e592333e6b8ec9620d8f924456b951202572..08cd1293f511712dbfbd2cecc1d3737a363add7f 100644
--- a/device/hid/hid_service_mac.cc
+++ b/device/hid/hid_service_mac.cc
@@ -143,16 +143,30 @@ void HidServiceMac::PlatformAddDevice(IOHIDDeviceRef hid_device) {
GetHidIntProperty(hid_device, CFSTR(kIOHIDVendorIDKey));
device_info.product_id =
GetHidIntProperty(hid_device, CFSTR(kIOHIDProductIDKey));
- device_info.usage =
- GetHidIntProperty(hid_device, CFSTR(kIOHIDPrimaryUsageKey));
- device_info.usage_page =
- GetHidIntProperty(hid_device, CFSTR(kIOHIDPrimaryUsagePageKey));
device_info.input_report_size =
GetHidIntProperty(hid_device, CFSTR(kIOHIDMaxInputReportSizeKey));
device_info.output_report_size =
GetHidIntProperty(hid_device, CFSTR(kIOHIDMaxOutputReportSizeKey));
device_info.feature_report_size =
GetHidIntProperty(hid_device, CFSTR(kIOHIDMaxFeatureReportSizeKey));
+ CFTypeRef deviceUsagePairsRaw =
+ IOHIDDeviceGetProperty(hid_device, CFSTR(kIOHIDDeviceUsagePairsKey));
+ CFArrayRef deviceUsagePairs =
+ base::mac::CFCast<CFArrayRef>(deviceUsagePairsRaw);
+ CFIndex deviceUsagePairsCount = CFArrayGetCount(deviceUsagePairs);
+ for (CFIndex i = 0; i < deviceUsagePairsCount; i++) {
+ HidUsageAndPage usage_and_page;
+ CFDictionaryRef deviceUsagePair = base::mac::CFCast<CFDictionaryRef>(
+ CFArrayGetValueAtIndex(deviceUsagePairs, i));
+ CFNumberRef usage_page_raw = base::mac::CFCast<CFNumberRef>(
+ CFDictionaryGetValue(deviceUsagePair, CFSTR(kIOHIDDeviceUsagePageKey)));
+ CFNumberGetValue(
+ usage_page_raw, kCFNumberSInt32Type, &usage_and_page.usage_page);
+ CFNumberRef usage_raw = base::mac::CFCast<CFNumberRef>(
+ CFDictionaryGetValue(deviceUsagePair, CFSTR(kIOHIDDeviceUsageKey)));
+ CFNumberGetValue(usage_raw, kCFNumberSInt32Type, &usage_and_page.usage);
+ device_info.usages.push_back(usage_and_page);
+ }
device_info.product_name =
GetHidStringProperty(hid_device, CFSTR(kIOHIDProductKey));
device_info.serial_number =

Powered by Google App Engine
This is Rietveld 408576698