chrome.hid : enrich device info with Top-Level collections usages

device/hid/hid_service_mac.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/hid/hid_service_mac.h"
 
 #include <CoreFoundation/CoreFoundation.h>
 #include <IOKit/hid/IOHIDManager.h>
 
 #include <string>
@@ skipping 125 matching lines @@
   // Note that our ownership of hid_device is implied if calling this method.
   // It is balanced in PlatformRemoveDevice.
   DCHECK(thread_checker_.CalledOnValidThread());
 
   HidDeviceInfo device_info;
   device_info.device_id = hid_device;
   device_info.vendor_id =
       GetHidIntProperty(hid_device, CFSTR(kIOHIDVendorIDKey));
   device_info.product_id =
       GetHidIntProperty(hid_device, CFSTR(kIOHIDProductIDKey));
-  device_info.usage =
-      GetHidIntProperty(hid_device, CFSTR(kIOHIDPrimaryUsageKey));
-  device_info.usage_page =
-      GetHidIntProperty(hid_device, CFSTR(kIOHIDPrimaryUsagePageKey));
   device_info.input_report_size =
       GetHidIntProperty(hid_device, CFSTR(kIOHIDMaxInputReportSizeKey));
   device_info.output_report_size =
       GetHidIntProperty(hid_device, CFSTR(kIOHIDMaxOutputReportSizeKey));
   device_info.feature_report_size =
       GetHidIntProperty(hid_device, CFSTR(kIOHIDMaxFeatureReportSizeKey));
+  CFTypeRef deviceUsagePairsRaw =
+      IOHIDDeviceGetProperty(hid_device, CFSTR(kIOHIDDeviceUsagePairsKey));
+  CFArrayRef deviceUsagePairs =
+      base::mac::CFCast<CFArrayRef>(deviceUsagePairsRaw);
+  CFIndex deviceUsagePairsCount = CFArrayGetCount(deviceUsagePairs);
+  for (CFIndex i = 0; i < deviceUsagePairsCount; i++) {
+    CFDictionaryRef deviceUsagePair = base::mac::CFCast<CFDictionaryRef>(
+        CFArrayGetValueAtIndex(deviceUsagePairs, i));
+    CFNumberRef usage_raw = base::mac::CFCast<CFNumberRef>(
+        CFDictionaryGetValue(deviceUsagePair, CFSTR(kIOHIDDeviceUsageKey)));
+    uint16_t usage;
+    CFNumberGetValue(usage_raw, kCFNumberSInt32Type, &usage);
+    CFNumberRef page_raw = base::mac::CFCast<CFNumberRef>(
+        CFDictionaryGetValue(deviceUsagePair, CFSTR(kIOHIDDeviceUsagePageKey)));
+    UsagePage page;

[Ken Rockot(use gerrit already), 2014/04/24 19:26:18]

Gah. Sorry. I should have been more careful about what I wrote here.

UsagePage isn't a type.

HidUsageAndPage::Page is the type.

[jracle (use Gerrit), 2014/04/24 19:47:01]

Gasp, wish I could rebuild.
Let's retry, if we reach 15 I owe you a beer!

+    CFNumberGetValue(page_raw, kCFNumberSInt32Type, &page);
+    device_info.usages.push_back(HidUsageAndPage(usage, page));
+  }
   device_info.product_name =
       GetHidStringProperty(hid_device, CFSTR(kIOHIDProductKey));
   device_info.serial_number =
       GetHidStringProperty(hid_device, CFSTR(kIOHIDSerialNumberKey));
   AddDevice(device_info);
 }
 
 void HidServiceMac::PlatformRemoveDevice(IOHIDDeviceRef hid_device) {
   DCHECK(thread_checker_.CalledOnValidThread());
   RemoveDevice(hid_device);
   CFRelease(hid_device);
 }
 
 scoped_refptr<HidConnection> HidServiceMac::Connect(
     const HidDeviceId& device_id) {
   DCHECK(thread_checker_.CalledOnValidThread());
   HidDeviceInfo device_info;
   if (!GetDeviceInfo(device_id, &device_info))
     return NULL;
   return scoped_refptr<HidConnection>(new HidConnectionMac(device_info));
 }
 
 }  // namespace device