Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2255093004: Make __DATE__ and __TIME__ to evaluate to an empty string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 ":compiler_cpu_abi", 159 ":compiler_cpu_abi",
160 ":compiler_codegen", 160 ":compiler_codegen",
161 ] 161 ]
162 162
163 # In general, Windows is totally different, but all the other builds share 163 # In general, Windows is totally different, but all the other builds share
164 # some common GCC configuration. 164 # some common GCC configuration.
165 if (!is_win) { 165 if (!is_win) {
166 # Common GCC compiler flags setup. 166 # Common GCC compiler flags setup.
167 # -------------------------------- 167 # --------------------------------
168 cflags += [ "-fno-strict-aliasing" ] # See http://crbug.com/32204 168 cflags += [ "-fno-strict-aliasing" ] # See http://crbug.com/32204
169
170 # Eliminate build metadata (__DATE__ and __TIME_) for deterministic build.
171 # See https://crbug.com/314403
172 cflags += [
173 "-Wno-builtin-macro-redefined",
Nico 2016/08/24 14:41:12 This looks pretty hacky. Can we instead teach the
174 "-D__DATE__=",
Nico 2016/08/24 14:41:12 __DATE__ and __TIME__ are supposed to be string co
175 "-D__TIME__=",
176 ]
177
169 cflags_cc += [ 178 cflags_cc += [
170 # If this is removed then remove the corresponding /Zc:threadSafeInit- for 179 # If this is removed then remove the corresponding /Zc:threadSafeInit- for
171 # Windows. 180 # Windows.
172 "-fno-threadsafe-statics", 181 "-fno-threadsafe-statics",
173 182
174 # Not exporting C++ inline functions can generally be applied anywhere 183 # Not exporting C++ inline functions can generally be applied anywhere
175 # so we do so here. Normal function visibility is controlled by 184 # so we do so here. Normal function visibility is controlled by
176 # //build/config/gcc:symbol_visibility_hidden. 185 # //build/config/gcc:symbol_visibility_hidden.
177 "-fvisibility-inlines-hidden", 186 "-fvisibility-inlines-hidden",
178 ] 187 ]
(...skipping 1402 matching lines...) Expand 10 before | Expand all | Expand 10 after
1581 1590
1582 if (is_ios || is_mac) { 1591 if (is_ios || is_mac) {
1583 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1592 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1584 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1593 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1585 config("enable_arc") { 1594 config("enable_arc") {
1586 common_flags = [ "-fobjc-arc" ] 1595 common_flags = [ "-fobjc-arc" ]
1587 cflags_objc = common_flags 1596 cflags_objc = common_flags
1588 cflags_objcc = common_flags 1597 cflags_objcc = common_flags
1589 } 1598 }
1590 } 1599 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698