Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2255073002: Convert editing/deleting/delete-block-merge-contents-01[2-7].html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/delete-block-merge-contents-01[2-7].html to use w3c test harness This patch converts "editing/deleting/delete-block-merge-contents-01[2-7].html" to use w3c test harness to simplify test script for improving readability, and consolidates into "delete_block_merge_whitespace.html" since samples of them are similar. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/b353c215fba65e994515ed38b9a8bdf50651c088 Cr-Commit-Position: refs/heads/master@{#412771}

Patch Set 1 : 2016-08-18T13:59:29 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -993 lines) Patch
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-012.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-013.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-014.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-015.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-016.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-block-merge-contents-017.html View 1 chunk +0 lines, -40 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_whitespace.html View 1 chunk +119 lines, -0 lines 1 comment Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-012-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-012-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-013-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-013-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-014-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-014-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-015-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-015-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-016-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-016-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-017-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-block-merge-contents-017-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-012-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-012-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-013-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-013-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-014-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-014-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-015-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-015-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-016-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-016-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-017-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-block-merge-contents-017-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-012-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-012-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-013-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-013-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-014-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-014-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-015-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-015-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-016-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-016-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-017-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-block-merge-contents-017-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-18 06:13:19 UTC) #5
Xiaocheng
lgtm with nit https://codereview.chromium.org/2255073002/diff/1/third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_whitespace.html File third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_whitespace.html (right): https://codereview.chromium.org/2255073002/diff/1/third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_whitespace.html#newcode61 third_party/WebKit/LayoutTests/editing/deleting/delete_block_merge_whitespace.html:61: 'Select with surrounding whitespace'); nit: should ...
4 years, 4 months ago (2016-08-18 08:03:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255073002/1
4 years, 4 months ago (2016-08-18 08:30:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 08:36:37 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:38:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b353c215fba65e994515ed38b9a8bdf50651c088
Cr-Commit-Position: refs/heads/master@{#412771}

Powered by Google App Engine
This is Rietveld 408576698