Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2255063002: Convert editing/deleting/delete-at-paragraph-boundaries-00[1-5].html to use w3c test harness (Closed)

Created:
4 years, 4 months ago by yosin_UTC9
Modified:
4 years, 4 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/delete-at-paragraph-boundaries-00[1-5].html to use w3c test harness This patch converts "editing/deleting/delete-at-paragraph-boundaries-00[1-5].html" to use w3c test harness to simplify test script for improving readability, and consolidates into "delete_at_paragraph_boundaries.html" since samples of them are similar. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/2c56c7194d65bb9a5a97ecfbb3dd8b5738717052 Cr-Commit-Position: refs/heads/master@{#412781}

Patch Set 1 : 2016-08-18T13:13:01 #

Total comments: 10

Patch Set 2 : 2016-08-18T16:54:17 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -805 lines) Patch
D third_party/WebKit/LayoutTests/editing/deleting/delete-at-paragraph-boundaries-001.html View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-at-paragraph-boundaries-002.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-at-paragraph-boundaries-003.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-at-paragraph-boundaries-004.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/delete-at-paragraph-boundaries-005.html View 1 chunk +0 lines, -64 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/deleting/delete_at_paragraph_boundaries.html View 1 1 chunk +87 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-at-paragraph-boundaries-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-at-paragraph-boundaries-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-at-paragraph-boundaries-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-at-paragraph-boundaries-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-at-paragraph-boundaries-002-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-at-paragraph-boundaries-003-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-at-paragraph-boundaries-004-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-at-paragraph-boundaries-005-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
yosin_UTC9
PTAL
4 years, 4 months ago (2016-08-18 05:04:27 UTC) #5
Xiaocheng
The selections do not match those in the original tests. Please fix. https://codereview.chromium.org/2255063002/diff/1/third_party/WebKit/LayoutTests/editing/deleting/delete_at_paragraph_boundaries.html File third_party/WebKit/LayoutTests/editing/deleting/delete_at_paragraph_boundaries.html ...
4 years, 4 months ago (2016-08-18 06:57:00 UTC) #8
yosin_UTC9
PTAL Add a missing test case https://codereview.chromium.org/2255063002/diff/1/third_party/WebKit/LayoutTests/editing/deleting/delete_at_paragraph_boundaries.html File third_party/WebKit/LayoutTests/editing/deleting/delete_at_paragraph_boundaries.html (right): https://codereview.chromium.org/2255063002/diff/1/third_party/WebKit/LayoutTests/editing/deleting/delete_at_paragraph_boundaries.html#newcode10 third_party/WebKit/LayoutTests/editing/deleting/delete_at_paragraph_boundaries.html:10: '<p>A</p><p><br></p><p>^B|</p><p><br></p>', On 2016/08/18 ...
4 years, 4 months ago (2016-08-18 08:58:42 UTC) #11
Xiaocheng
lgtm
4 years, 4 months ago (2016-08-18 09:22:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255063002/20001
4 years, 4 months ago (2016-08-18 09:23:20 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 10:03:43 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 10:05:28 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c56c7194d65bb9a5a97ecfbb3dd8b5738717052
Cr-Commit-Position: refs/heads/master@{#412781}

Powered by Google App Engine
This is Rietveld 408576698