Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2788)

Unified Diff: chrome/browser/resources/md_history/synced_device_manager.js

Issue 2255033002: [MD History] Copy stats from the old history page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sidebar_stats
Patch Set: add_stats Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/synced_device_manager.js
diff --git a/chrome/browser/resources/md_history/synced_device_manager.js b/chrome/browser/resources/md_history/synced_device_manager.js
index 4d9a6fe102b50a60b23267bc85bc9dcbe4fbbb5a..e2633f9863f9e3dcd7fa719a71ffe1fa41455db4 100644
--- a/chrome/browser/resources/md_history/synced_device_manager.js
+++ b/chrome/browser/resources/md_history/synced_device_manager.js
@@ -55,7 +55,9 @@ Polymer({
fetchingSyncedTabs_: {
type: Boolean,
value: false,
- }
+ },
+
+ hasSeenForeignData_: Boolean,
},
listeners: {
@@ -67,6 +69,9 @@ Polymer({
attached: function() {
// Update the sign in state.
chrome.send('otherDevicesInitialized');
+ md_history.BrowserService.getInstance().recordHistogram(
+ SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.INITIALIZED,
+ SyncedTabsHistogram.LIMIT);
},
/**
@@ -128,20 +133,32 @@ Polymer({
onToggleMenu_: function(e) {
this.$.menu.get().then(function(menu) {
menu.toggleMenu(e.detail.target, e.detail.tag);
+ if (menu.menuOpen) {
+ md_history.BrowserService.getInstance().recordHistogram(
+ SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.SHOW_SESSION_MENU,
+ SyncedTabsHistogram.LIMIT);
+ }
});
},
onOpenAllTap_: function() {
var menu = assert(this.$.menu.getIfExists());
- md_history.BrowserService.getInstance().openForeignSessionAllTabs(
+ var browserService = md_history.BrowserService.getInstance();
+ browserService.recordHistogram(
+ SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.OPEN_ALL,
+ SyncedTabsHistogram.LIMIT);
+ browserService.openForeignSessionAllTabs(
menu.itemData);
menu.closeMenu();
},
onDeleteSessionTap_: function() {
var menu = assert(this.$.menu.getIfExists());
- md_history.BrowserService.getInstance().deleteForeignSession(
- menu.itemData);
+ var browserService = md_history.BrowserService.getInstance();
+ browserService.recordHistogram(
+ SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.HIDE_FOR_NOW,
+ SyncedTabsHistogram.LIMIT);
+ browserService.deleteForeignSession(menu.itemData);
menu.closeMenu();
},
@@ -207,6 +224,13 @@ Polymer({
if (!sessionList)
return;
+ if (sessionList.length > 0 && !this.hasSeenForeignData_) {
+ this.hasSeenForeignData_ = true;
+ md_history.BrowserService.getInstance().recordHistogram(
+ SYNCED_TABS_HISTOGRAM_NAME, SyncedTabsHistogram.HAS_FOREIGN_DATA,
+ SyncedTabsHistogram.LIMIT);
+ }
+
// First, update any existing devices that have changed.
var updateCount = Math.min(sessionList.length, this.syncedDevices_.length);
for (var i = 0; i < updateCount; i++) {

Powered by Google App Engine
This is Rietveld 408576698