Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1771)

Unified Diff: chrome/browser/resources/md_history/history_list_behavior.js

Issue 2255033002: [MD History] Copy stats from the old history page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sidebar_stats
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/history_list_behavior.js
diff --git a/chrome/browser/resources/md_history/history_list_behavior.js b/chrome/browser/resources/md_history/history_list_behavior.js
index 230139f0f6593d0a306ad753f864088a55f16d7a..82d7860c5db50e2d5cb5b1a78d90cb5262db0e37 100644
--- a/chrome/browser/resources/md_history/history_list_behavior.js
+++ b/chrome/browser/resources/md_history/history_list_behavior.js
@@ -172,6 +172,14 @@ var HistoryListBehavior = {
object: array,
type: 'splice'
});
+ var browserService = md_history.BrowserService.getInstance();
tsergeant 2016/08/18 04:14:34 You need to be really careful about grouped histor
calamity 2016/08/19 13:59:44 Oh wups, this is meant to be item.index. Added mo
+ browserService.recordHistogram(
+ 'HistoryPage.RemoveEntryPosition', index, UMA_MAX_BUCKET_VALUE);
+ if (index <= UMA_MAX_SUBSET_BUCKET_VALUE) {
+ browserService.recordHistogram(
+ 'HistoryPage.RemoveEntryPositionSubset', index,
+ UMA_MAX_SUBSET_BUCKET_VALUE);
+ }
}
}.bind(this));

Powered by Google App Engine
This is Rietveld 408576698