chrome/browser/resources/settings/route.js - Issue 2255023002: Settings: Remove /advanced usage as URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/route.js

Issue 2255023002: Settings: Remove /advanced usage as URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/route.js

diff --git a/chrome/browser/resources/settings/route.js b/chrome/browser/resources/settings/route.js

index ec097c22c568cccce66fe0f156f8620d88b04298..78fd1ee6bfeecc07e78160b5e063f039f520f507 100644

--- a/chrome/browser/resources/settings/route.js

+++ b/chrome/browser/resources/settings/route.js

@@ -266,7 +266,8 @@ cr.define('settings', function() {

initializeRouteFromUrlCalled_ = true;

var route = getRouteForPath(window.location.pathname);

- if (route) {

+ // Never allow direct navigation to ADVANCED.

+ if (route && route != Route.ADVANCED) {

currentRoute_ = route;

currentQueryParameters_ = new URLSearchParams(window.location.search);

} else {

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »