Settings: Remove /advanced usage as URL.

chrome/browser/resources/settings/route.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /**
    * Class for navigable routes. May only be instantiated within this file.
    * @constructor
    * @param {string} path
    * @private
@@ skipping 248 matching lines @@
   var initializeRouteFromUrlCalled_ = false;
 
   /**
    * Initialize the route and query params from the URL.
    */
   var initializeRouteFromUrl = function() {
     assert(!initializeRouteFromUrlCalled_);
     initializeRouteFromUrlCalled_ = true;
 
     var route = getRouteForPath(window.location.pathname);
-    if (route) {
+    // Never allow direct navigation to ADVANCED.
+    if (route && route != Route.ADVANCED) {

[dschuyler, 2016/08/17 22:54:12]

Can we drop advanced altogether? I added it as
part of MD settings. So there shouldn't be any
legacy to support.

[tommycli, 2016/08/17 23:56:25]

Can't easily drop it. It's needed to do all the ADVANCED.contains(Route.foo)
tests. We could add a separate list of Advanced routes, but it would be more
cumbersome than just keeping it as a 'virtual' route.

       currentRoute_ = route;
       currentQueryParameters_ = new URLSearchParams(window.location.search);
     } else {
       window.history.replaceState(undefined, '', Route.BASIC.path);
     }
   };
 
   /**
    * Helper function to set the current route and notify all observers.
    * @param {!settings.Route} route
@@ skipping 46 matching lines @@
   return {
     Route: Route,
     RouteObserverBehavior: RouteObserverBehavior,
     getRouteForPath: getRouteForPath,
     initializeRouteFromUrl: initializeRouteFromUrl,
     getCurrentRoute: getCurrentRoute,
     getQueryParameters: getQueryParameters,
     navigateTo: navigateTo,
   };
 });