Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2255023002: Settings: Remove /advanced usage as URL. (Closed)

Created:
4 years, 4 months ago by tommycli
Modified:
4 years, 4 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Remove /advanced usage as URL. After this CL, nothing ever explicitly navigates to the Advanced route. Navigations by URL to /advanced redirect to BASIC. BUG=628502 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2 Cr-Commit-Position: refs/heads/master@{#412919}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix tests #

Patch Set 3 : remove stray line #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/resources/settings/route.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/test/data/webui/settings/advanced_page_browsertest.js View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M chrome/test/data/webui/settings/languages_page_browsertest.js View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M chrome/test/data/webui/settings/settings_page_browsertest.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/settings_subpage_browsertest.js View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
tommycli
dschuyler: PTAL. One more, sry.
4 years, 4 months ago (2016-08-17 22:43:40 UTC) #4
dschuyler
https://codereview.chromium.org/2255023002/diff/1/chrome/browser/resources/settings/route.js File chrome/browser/resources/settings/route.js (right): https://codereview.chromium.org/2255023002/diff/1/chrome/browser/resources/settings/route.js#newcode270 chrome/browser/resources/settings/route.js:270: if (route && route != Route.ADVANCED) { Can we ...
4 years, 4 months ago (2016-08-17 22:54:12 UTC) #6
tommycli
https://codereview.chromium.org/2255023002/diff/1/chrome/browser/resources/settings/route.js File chrome/browser/resources/settings/route.js (right): https://codereview.chromium.org/2255023002/diff/1/chrome/browser/resources/settings/route.js#newcode270 chrome/browser/resources/settings/route.js:270: if (route && route != Route.ADVANCED) { On 2016/08/17 ...
4 years, 4 months ago (2016-08-17 23:56:25 UTC) #7
dschuyler
Ah, thanks for the explanation. LGTM
4 years, 4 months ago (2016-08-18 01:20:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255023002/1
4 years, 4 months ago (2016-08-18 15:30:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/282411)
4 years, 4 months ago (2016-08-18 16:15:15 UTC) #12
tommycli
FYI: had to update a few tests to make it play nice with no more ...
4 years, 4 months ago (2016-08-18 17:00:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255023002/40001
4 years, 4 months ago (2016-08-18 18:00:01 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/263608)
4 years, 4 months ago (2016-08-18 18:33:00 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255023002/60001
4 years, 4 months ago (2016-08-18 19:06:08 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-18 20:05:15 UTC) #27
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 20:10:10 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2
Cr-Commit-Position: refs/heads/master@{#412919}

Powered by Google App Engine
This is Rietveld 408576698