Settings: Remove /advanced usage as URL.

Settings: Remove /advanced usage as URL.

After this CL, nothing ever explicitly navigates to the Advanced route.

Navigations by URL to /advanced redirect to BASIC.

BUG=628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2
Cr-Commit-Position: refs/heads/master@{#412919}

[tommycli, 2016-08-17 22:41:02]

Description was changed from

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever navigates to the Advanced route.


BUG=
==========

to

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever navigates to the Advanced route.


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-17 22:43:11]

Description was changed from

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever navigates to the Advanced route.


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever navigates to the Advanced route.

Navigations by URL to /advanced redirect to BASIC.

BUG=628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-17 22:43:11]

tommycli@chromium.org changed reviewers:
+ dschuyler@chromium.org

[tommycli, 2016-08-17 22:43:40]

dschuyler: PTAL. One more, sry.

[tommycli, 2016-08-17 22:47:41]

Description was changed from

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever navigates to the Advanced route.

Navigations by URL to /advanced redirect to BASIC.

BUG=628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever explicitly navigates to the Advanced route.

Navigations by URL to /advanced redirect to BASIC.

BUG=628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-08-17 22:54:12]

https://codereview.chromium.org/2255023002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2255023002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:270: if (route && route !=
Route.ADVANCED) {
Can we drop advanced altogether? I added it as
part of MD settings. So there shouldn't be any
legacy to support.

[tommycli, 2016-08-17 23:56:25]

https://codereview.chromium.org/2255023002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/route.js (right):

https://codereview.chromium.org/2255023002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/route.js:270: if (route && route !=
Route.ADVANCED) {
On 2016/08/17 22:54:12, dschuyler wrote:
> Can we drop advanced altogether? I added it as
> part of MD settings. So there shouldn't be any
> legacy to support.

Can't easily drop it. It's needed to do all the ADVANCED.contains(Route.foo)
tests. We could add a separate list of Advanced routes, but it would be more
cumbersome than just keeping it as a 'virtual' route.

[dschuyler, 2016-08-18 01:20:12]

Ah, thanks for the explanation.
LGTM

[tommycli, 2016-08-18 15:30:05]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-18 15:30:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 16:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 16:15:15]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2016-08-18 16:59:05]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 16:59:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-18 17:00:44]

FYI: had to update a few tests to make it play nice with no more /advanced

[tommycli, 2016-08-18 17:51:19]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-08-18 17:51:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2255023002/#ps40001
(title: "remove stray line")

[tommycli, 2016-08-18 17:51:20]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-08-18 17:59:28]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:00:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 18:32:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:33:00]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2016-08-18 19:05:28]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-08-18 19:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2255023002/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2016-08-18 19:06:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 20:05:13]

Description was changed from

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever explicitly navigates to the Advanced route.

Navigations by URL to /advanced redirect to BASIC.

BUG=628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever explicitly navigates to the Advanced route.

Navigations by URL to /advanced redirect to BASIC.

BUG=628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-18 20:05:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-18 20:10:09]

Description was changed from

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever explicitly navigates to the Advanced route.

Navigations by URL to /advanced redirect to BASIC.

BUG=628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Remove /advanced usage as URL.

After this CL, nothing ever explicitly navigates to the Advanced route.

Navigations by URL to /advanced redirect to BASIC.

BUG=628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2
Cr-Commit-Position: refs/heads/master@{#412919}
==========

[commit-bot: I haz the power, 2016-08-18 20:10:10]

Patchset 4 (id:??) landed as
https://crrev.com/cd81492dada5b5ad4c2f6914323145cd8a541eb2
Cr-Commit-Position: refs/heads/master@{#412919}