Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3505)

Unified Diff: bus/ibusimpl.c

Issue 2255002: When the previous engine name is unknown, switch to the next engine in menu. (Closed) Base URL: ssh://git@gitrw.chromium.org//ibus.git
Patch Set: address comments Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bus/ibusimpl.c
diff --git a/bus/ibusimpl.c b/bus/ibusimpl.c
index a531ca9f102b9263b44cdb2d6ed599acd79c4ef6..3c753dde6b0b9e3a421b9b3e59f14700c36c79a2 100644
--- a/bus/ibusimpl.c
+++ b/bus/ibusimpl.c
@@ -976,6 +976,14 @@ bus_ibus_impl_context_request_previous_engine (BusIBusImpl *ibus,
engine_name = ibus->global_previous_engine_name;
}
+ /*
+ * If the previous engine name is not found, switch to the next engine
+ * in the menu. This behavior is better than doing nothing.
+ */
+ if (!engine_name) {
+ bus_ibus_impl_context_request_next_engine_in_menu(ibus, context);
+ return;
+ }
_context_request_engine_cb (context, engine_name, ibus);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698