Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2254993003: Avoid creating sync token when only change is new hardware video frame. (Closed)

Created:
4 years, 4 months ago by jbauman
Modified:
4 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid creating sync token when only change is new hardware video frame. Once we get the picture ready IPC the GPU has already done all the processing it needs to for the frame, so the renderer doesn't need to create a new sync token. We can instead use the same sync token every frame to avoid a synchronous IPC to the GPU process. BUG=575856 Committed: https://crrev.com/1d06968c477a6db0d33804d346ed590c19251e0b Cr-Commit-Position: refs/heads/master@{#412934}

Patch Set 1 #

Patch Set 2 : fix deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M content/renderer/media/renderer_gpu_video_accelerator_factories.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M media/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/renderers/gpu_video_accelerator_factories.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/renderers/mock_gpu_video_accelerator_factories.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
jbauman
4 years, 4 months ago (2016-08-18 21:03:01 UTC) #10
sandersd (OOO until July 31)
lgtm
4 years, 4 months ago (2016-08-18 21:21:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2254993003/20001
4 years, 4 months ago (2016-08-18 21:23:56 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 21:28:32 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 21:30:12 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d06968c477a6db0d33804d346ed590c19251e0b
Cr-Commit-Position: refs/heads/master@{#412934}

Powered by Google App Engine
This is Rietveld 408576698