Milo: Add task expired as a failure status

milo/appengine/swarming/build.go

 // Copyright 2015 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package swarming
 
 import (
         "bytes"
         "encoding/json"
         "fmt"
@@ skipping 264 matching lines @@
 
         switch sr.State {
         case TaskRunning:
                 step.Status = miloProto.Status_RUNNING
 
         case TaskPending:
                 step.Status = miloProto.Status_PENDING
 
         case TaskExpired, TaskTimedOut, TaskBotDied:
                 step.Status = miloProto.Status_FAILURE
-                step.FailureDetails = &miloProto.FailureDetails{
-                        Type: miloProto.FailureDetails_INFRA,
-                }
 
                 switch sr.State {
                 case TaskExpired:
-                        step.FailureDetails.Text = "Task expired"
+                        step.FailureDetails = &miloProto.FailureDetails{
+                                Type: miloProto.FailureDetails_EXPIRED,
+                                Text: "Task expired",
+                        }
                 case TaskTimedOut:
-                        step.FailureDetails.Text = "Task timed out"
+                        step.FailureDetails = &miloProto.FailureDetails{
+                                Type: miloProto.FailureDetails_INFRA,
+                                Text: "Task timed out",
+                        }
                 case TaskBotDied:
-                        step.FailureDetails.Text = "Bot died"
+                        step.FailureDetails = &miloProto.FailureDetails{
+                                Type: miloProto.FailureDetails_INFRA,
+                                Text: "Bot died",
+                        }
                 }
 
         case TaskCanceled:
                 // Cancelled build is user action, so it is not an infra failure.
                 step.Status = miloProto.Status_FAILURE
                 step.FailureDetails = &miloProto.FailureDetails{
                         Type: miloProto.FailureDetails_CANCELLED,
                         Text: "Task cancelled by user",
                 }
 
@@ skipping 192 matching lines @@
         case *miloProto.Link_Url:
                 return &resp.Link{
                         Label: l.Label,
                         URL:   t.Url,
                 }
 
         default:
                 return nil
         }
 }